Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add logs for new client event #2088

Merged
merged 2 commits into from
Sep 25, 2023
Merged

chore: add logs for new client event #2088

merged 2 commits into from
Sep 25, 2023

Conversation

tmspzz
Copy link
Contributor

@tmspzz tmspzz commented Sep 25, 2023

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Logs are missing when the processing of a new client event happens

Solutions

Add logs for success and failure

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@tmspzz tmspzz requested review from a team, typfel, gongracr, MohamadJaara, mchenani and Garzas and removed request for a team September 25, 2023 13:27
gongracr
gongracr approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@gongracr gongracr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍑

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023 •
edited
Loading

Unit Test Results

   410 files     410 suites   24s ⏱️
2 251 tests 2 131 ✔️ 120 💤 0 ❌

Results for commit 90faea3.

♻️ This comment has been updated with latest results.

@yamilmedina yamilmedina enabled auto-merge (squash) September 25, 2023 14:53
@datadog-wireapp
Copy link

Datadog Report

Branch report: chore/add-logs-new-client
Commit report: b304955

✅ kalium-jvm: 0 Failed, 0 New Flaky, 2248 Passed, 98 Skipped, 9m 45s Wall Time

@yamilmedina yamilmedina merged commit 5c74b6e into release/candidate Sep 25, 2023
14 checks passed
@yamilmedina yamilmedina deleted the chore/add-logs-new-client branch September 25, 2023 15:17
@github-actions github-actions bot mentioned this pull request Sep 25, 2023
Merged
3 tasks
github-actions bot pushed a commit that referenced this pull request Sep 25, 2023
@tmspzz @yamilmedina @github-actions
chore: add logs for new client event (#2088)
68d7cbd 
Co-authored-by: Yamil Medina <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Sep 26, 2023
@github-actions @tmspzz
@yamilmedina @vitorhugods
chore: add logs for new client event (#2088) (#2089)
5343e2f 
Co-authored-by: Tommaso Piazza <[email protected]>
Co-authored-by: Yamil Medina <[email protected]>
Co-authored-by: Vitor Hugo Schwaab <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@typfel typfel typfel approved these changes

@gongracr gongracr gongracr approved these changes

@yamilmedina yamilmedina yamilmedina approved these changes

@vitorhugods vitorhugods vitorhugods approved these changes

@ohassine ohassine ohassine approved these changes

@MohamadJaara MohamadJaara Awaiting requested review from MohamadJaara MohamadJaara was automatically assigned from wireapp/android

@mchenani mchenani Awaiting requested review from mchenani mchenani was automatically assigned from wireapp/android

@Garzas Garzas Awaiting requested review from Garzas Garzas was automatically assigned from wireapp/android

Assignees

@tmspzz tmspzz

Labels
👕 size: S type: chore 🧹
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tmspzz @typfel @gongracr @yamilmedina @vitorhugods @ohassine