feat: handle composite action confermation message [part-3] #1901

MohamadJaara · 2023-07-20T09:19:56Z

PR Submission Checklist for internal contributors

The PR Title
- conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
- contains a reference JIRA issue number like SQPIT-764
- answers the question: If merged, this PR will: ... ³
The PR Description
- is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

when executing a message action like clicking a button, the receiver will respond with an Action Confirmation message
this message will contain which button is activated

Solutions

handle this event

Dependencies (Optional)

If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.

Needs releases with:

GitHub link to other pull request

Testing

Test Coverage (Optional)

I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

PR Post Submission Checklist for internal contributors (Optional)

Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References

https://sparkbox.com/foundry/semantic_commit_messages
https://github.com/wireapp/.github#usage
E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

…s/map_from_to_proto

…/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]>

…s/map_from_to_proto # Conflicts: # persistence/src/commonMain/db_user/migrations/49.sqm

…posit_messages/handle_button_click_actions

…s/handle_button_click_actions

…o feat/composit_messages/handle_Composite_action_message

github-actions · 2023-07-20T10:28:46Z

Unit Test Results

  408 files +1   408 suites +1 2m 25s ⏱️ +25s
2 194 tests +3 2 096 ✔️ +3 98 💤 ±0 0 ❌ ±0

Results for commit 14a3c33. ± Comparison against base commit 7824818.

♻️ This comment has been updated with latest results.

…o feat/composit_messages/handle_Composite_action_message

…s/handle_Composite_action_message # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/CompositeMessageRepository.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/ProtoContentMapper.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt # logic/src/commonTest/kotlin/com/wire/kalium/logic/data/message/MessageMetaDataRepositoryTest.kt

* feat: receive and store composite messages [part-1] (#1888) * receive composite messages * map composite to proto * detekt * detekt * db migration * db migration * sqm * map to composite entity * detekt * remove is pending state from the DB * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * address PR comments * detekt * remove composite message preview mapping * fix migration * merge issues * address PR comments * address PR comments * detekt --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> * feat: use case to send Message Button Action [part-2] (#1896) * receive composite messages * map composite to proto * detekt * detekt * db migration * db migration * sqm * map to composite entity * detekt * remove is pending state from the DB * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * address PR comments * detekt * remove composite message preview mapping * fix migration * feat: use case to execute composite message action * expose use case to message scope * missing param * rename use case * docs * map to proto * merge issues * address PR comments * address PR comments * detekt * sent the message only to the message original sender * detekt * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/data/message/MessageMetaDataRepositoryTest.kt Co-authored-by: Alexandre Ferris <[email protected]> * PR comments --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> Co-authored-by: Alexandre Ferris <[email protected]> * feat: handle composite action confermation message [part-3] (#1901) * receive composite messages * map composite to proto * detekt * detekt * db migration * db migration * sqm * map to composite entity * detekt * remove is pending state from the DB * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * address PR comments * detekt * remove composite message preview mapping * fix migration * feat: use case to execute composite message action * expose use case to message scope * missing param * rename use case * docs * map to proto * merge issues * address PR comments * address PR comments * detekt * handle ButtonActionConfirmation event * add unit test * detekt * detekt * sent the message only to the message original sender * detekt --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> * feat: composite message preview [part-4] (#1908) * receive composite messages * map composite to proto * detekt * detekt * db migration * db migration * sqm * map to composite entity * detekt * remove is pending state from the DB * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * address PR comments * detekt * remove composite message preview mapping * fix migration * feat: use case to execute composite message action * expose use case to message scope * missing param * rename use case * docs * map to proto * merge issues * address PR comments * address PR comments * detekt * handle ButtonActionConfirmation event * add unit test * detekt * detekt * sent the message only to the message original sender * detekt * feat: map composite messages preview * Update persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/message/MessageMapper.kt Co-authored-by: Alexandre Ferris <[email protected]> --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> Co-authored-by: Alexandre Ferris <[email protected]> * fix: composite messages are not included in the getLastMessages query [part-5] (#1909) * include composite messages to message preview * detekt * feat: display composite message preview * add test * feat: composit messages backup [part-6] (#1914) * fea: include message buttons into the backup * import buttons * merge issues * unit test * merge issues * ignore Confirmation messages that are not fom the original message sender * test * cleanup * detekt * typo * typo * PR comments * trigger CI * empty --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> Co-authored-by: Alexandre Ferris <[email protected]> Co-authored-by: Tommaso Piazza <[email protected]>

* feat: receive and store composite messages [part-1] (#1888) * receive composite messages * map composite to proto * detekt * detekt * db migration * db migration * sqm * map to composite entity * detekt * remove is pending state from the DB * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * address PR comments * detekt * remove composite message preview mapping * fix migration * merge issues * address PR comments * address PR comments * detekt --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> * feat: use case to send Message Button Action [part-2] (#1896) * receive composite messages * map composite to proto * detekt * detekt * db migration * db migration * sqm * map to composite entity * detekt * remove is pending state from the DB * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * address PR comments * detekt * remove composite message preview mapping * fix migration * feat: use case to execute composite message action * expose use case to message scope * missing param * rename use case * docs * map to proto * merge issues * address PR comments * address PR comments * detekt * sent the message only to the message original sender * detekt * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/data/message/MessageMetaDataRepositoryTest.kt Co-authored-by: Alexandre Ferris <[email protected]> * PR comments --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> Co-authored-by: Alexandre Ferris <[email protected]> * feat: handle composite action confermation message [part-3] (#1901) * receive composite messages * map composite to proto * detekt * detekt * db migration * db migration * sqm * map to composite entity * detekt * remove is pending state from the DB * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * address PR comments * detekt * remove composite message preview mapping * fix migration * feat: use case to execute composite message action * expose use case to message scope * missing param * rename use case * docs * map to proto * merge issues * address PR comments * address PR comments * detekt * handle ButtonActionConfirmation event * add unit test * detekt * detekt * sent the message only to the message original sender * detekt --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> * feat: composite message preview [part-4] (#1908) * receive composite messages * map composite to proto * detekt * detekt * db migration * db migration * sqm * map to composite entity * detekt * remove is pending state from the DB * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * address PR comments * detekt * remove composite message preview mapping * fix migration * feat: use case to execute composite message action * expose use case to message scope * missing param * rename use case * docs * map to proto * merge issues * address PR comments * address PR comments * detekt * handle ButtonActionConfirmation event * add unit test * detekt * detekt * sent the message only to the message original sender * detekt * feat: map composite messages preview * Update persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/message/MessageMapper.kt Co-authored-by: Alexandre Ferris <[email protected]> --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> Co-authored-by: Alexandre Ferris <[email protected]> * fix: composite messages are not included in the getLastMessages query [part-5] (#1909) * include composite messages to message preview * detekt * feat: display composite message preview * add test * feat: composit messages backup [part-6] (#1914) * fea: include message buttons into the backup * import buttons * merge issues * unit test * merge issues * ignore Confirmation messages that are not fom the original message sender * test * cleanup * detekt * typo * typo * PR comments * feat: Get and save clients mlsPublicKeys * feat: Get and save clients mlsPublicKeys: code stly * feat: Get and save clients mlsPublicKeys: tests fix * feat: Get and save clients mlsPublicKeys: removed logs --------- Co-authored-by: Mohamad Jaara <[email protected]> Co-authored-by: Vitor Hugo Schwaab <[email protected]> Co-authored-by: Alexandre Ferris <[email protected]>

MohamadJaara and others added 30 commits July 16, 2023 12:06

receive composite messages

326bb08

Merge branch 'feat/composit_messages/epic' into feat/composit_message…

6bd12d1

…s/map_from_to_proto

map composite to proto

4023b3e

detekt

b46fc01

detekt

125315c

db migration

0bd4540

db migration

a835427

sqm

3554d74

map to composite entity

cd2e36a

detekt

b6bc952

remove is pending state from the DB

e6ebf82

Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message…

6970d27

…/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]>

Update logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message…

da4a856

…/MessageContent.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]>

address PR comments

e3527ae

detekt

f477546

remove composite message preview mapping

772dadc

fix migration

0b53dca

feat: use case to execute composite message action

073e8f0

expose use case to message scope

26e4479

missing param

0d233d7

rename use case

1adf9b6

docs

6d8db66

map to proto

c73a181

Merge branch 'feat/composit_messages/epic' into feat/composit_message…

642b963

…s/map_from_to_proto # Conflicts: # persistence/src/commonMain/db_user/migrations/49.sqm

merge issues

22d18b0

address PR comments

2db6932

address PR comments

d306fd8

Merge branch 'feat/composit_messages/map_from_to_proto' into feat/com…

f87ef20

…posit_messages/handle_button_click_actions

detekt

afc616f

Merge branch 'feat/composit_messages/map_from_to_proto' into feat/com…

ce59727

…posit_messages/handle_button_click_actions

MohamadJaara changed the base branch from develop to feat/composit_messages/handle_button_click_actions July 20, 2023 09:20

MohamadJaara requested review from vitorhugods, trOnk12, a team, mchenani, Garzas and saleniuk and removed request for a team July 20, 2023 09:20

github-actions bot added 🚨 Potential breaking changes type: feature ✨ 👕 size: XXL 👕 size: L and removed 👕 size: XXL labels Jul 20, 2023

MohamadJaara added 3 commits July 20, 2023 12:13

detekt

85e0b7d

Merge branch 'feat/composit_messages/epic' into feat/composit_message…

3b7957c

…s/handle_button_click_actions

Merge branch 'feat/composit_messages/handle_button_click_actions' int…

b0a8f57

…o feat/composit_messages/handle_Composite_action_message

MohamadJaara added 4 commits July 20, 2023 12:39

detekt

a07c737

sent the message only to the message original sender

c609b17

detekt

7824818

Merge branch 'feat/composit_messages/handle_button_click_actions' int…

14a3c33

…o feat/composit_messages/handle_Composite_action_message

Garzas approved these changes Jul 21, 2023

View reviewed changes

saleniuk approved these changes Jul 21, 2023

View reviewed changes

Base automatically changed from feat/composit_messages/handle_button_click_actions to feat/composit_messages/epic July 24, 2023 09:01

MohamadJaara merged commit be085c9 into feat/composit_messages/epic Jul 24, 2023
2 of 5 checks passed

MohamadJaara deleted the feat/composit_messages/handle_Composite_action_message branch July 24, 2023 09:09

MohamadJaara mentioned this pull request Jul 24, 2023

feat: composite messages #1916

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: handle composite action confermation message [part-3] #1901

feat: handle composite action confermation message [part-3] #1901

MohamadJaara commented Jul 20, 2023

github-actions bot commented Jul 20, 2023 •

edited

Loading

feat: handle composite action confermation message [part-3] #1901

feat: handle composite action confermation message [part-3] #1901

Conversation

MohamadJaara commented Jul 20, 2023

PR Submission Checklist for internal contributors

What's new in this PR?

Issues

Solutions

Dependencies (Optional)

Testing

Test Coverage (Optional)

How to Test

Notes (Optional)

Attachments (Optional)

PR Post Submission Checklist for internal contributors (Optional)

PR Post Merge Checklist for internal contributors

References

github-actions bot commented Jul 20, 2023 • edited Loading

Unit Test Results

github-actions bot commented Jul 20, 2023 •

edited

Loading