-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: handle adding participants while some of their backends are down (WPB-462) #1900
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1900 +/- ##
=============================================
+ Coverage 54.91% 54.96% +0.05%
- Complexity 1627 1630 +3
=============================================
Files 1013 1014 +1
Lines 37299 37343 +44
Branches 3351 3359 +8
=============================================
+ Hits 20481 20524 +43
+ Misses 15450 15449 -1
- Partials 1368 1370 +2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome 🚀 Just some comment about magic numbers in tests
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
In federated environments, there is a chance of unavailability backends while adding remote users.
Causes (Optional)
The whole operation fails and provides no feedback to the user.
Solutions
Parse new error when it is a federated error, handle the domain list to exclude those users and retry, finally generates a system message with
MessageContent.MemberChange.FailedToAdd
.Testing
Test Coverage (Optional)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.