chore(corecrypto): upgrade CoreCrypto to 1.0.0 pre.6 #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…t/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…t/e2ei/e2ei_usecase
This reverts commit 377c137.
…t/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/UserScope.kt
…/e2ei/e2ei_usecase # Conflicts: # cryptography/src/commonJvmAndroid/kotlin/com.wire.kalium.cryptography/MLSClientImpl.kt # cryptography/src/commonMain/kotlin/com/wire/kalium/cryptography/MLSClient.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/UserScope.kt
…/e2ei/upgrade_cc_1.0.0-pre.6
vitorhugods
approved these changes
Jul 18, 2023
Comment on lines
295
to
315
| /** | ||
| * Enroll Wire E2EI Enrollment Client for renewing certificate | ||
| * | ||
| * @return wire end to end identity client | ||
| */ | ||
| fun e2eiNewRotateEnrollment( | ||
| displayName: String?, | ||
| handle: String?, | ||
| expiryDays: UInt, | ||
| ciphetSuite: String | ||
| ): E2EIClient | ||
|
|
||
| /** | ||
| * Init MLSClient after enrollment | ||
| */ | ||
| fun e2eiMlsInitOnly(enrollment: E2EIClient, certificateChain: CertificateChain) | ||
|
|
||
| /** | ||
| * Generate new keypackages after E2EI certificate issued | ||
| */ | ||
| fun e2eiRotateAll(enrollment: E2EIClient, certificateChain: CertificateChain, newMLSKeyPackageCount: UInt) |
There was a problem hiding this comment.
Can we add tests to these functions? Maybe local integration tests like what was done with Alice/Bob for message sending?
Not sure how feasible or useful that would be. Just food for thoughts really.
There was a problem hiding this comment.
This tests are done in CC and we only mock them here; so no benefit in it.
…' into feat/e2ei/upgrade_cc_1.0.0-pre.6
Codecov Report
@@ Coverage Diff @@
## develop #1892 +/- ##
=============================================
- Coverage 54.91% 54.91% -0.01%
Complexity 1627 1627
=============================================
Files 1013 1013
Lines 37299 37299
Branches 3351 3351
=============================================
- Hits 20484 20481 -3
- Misses 15448 15451 +3
Partials 1367 1367
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
typfel
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Upgrading CoreCrypto to 1.0.0 pre.6 and adopting new functions for mls initialization with E2EI.\
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.