Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default value of camera for incoming calls (WPB-1712) (RC) #1881

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Same PR as #1880 to be merged into RC branch


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 13, 2023

Unit Test Results

   363 files     363 suites   21s ⏱️
1 934 tests 1 818 ✔️ 116 💤 0

Results for commit 42b5cdc.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/candidate@211ae8a). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             release/candidate    #1881   +/-   ##
====================================================
  Coverage                     ?   54.38%           
  Complexity                   ?     1524           
====================================================
  Files                        ?      969           
  Lines                        ?    35789           
  Branches                     ?     3194           
====================================================
  Hits                         ?    19464           
  Misses                       ?    15036           
  Partials                     ?     1289           

Copy link
Contributor

@tmspzz tmspzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about AVS

@ohassine ohassine changed the title fix: set default value of camera for incoming calls ((WPB-1712) fix: set default value of camera for incoming calls ((WPB-1712) (RC) Jul 14, 2023
@ohassine ohassine changed the title fix: set default value of camera for incoming calls ((WPB-1712) (RC) fix: set default value of camera for incoming calls (WPB-1712) (RC) Jul 14, 2023
@tmspzz tmspzz enabled auto-merge (squash) July 14, 2023 08:36
@tmspzz tmspzz merged commit 1ee898c into release/candidate Jul 14, 2023
9 checks passed
@tmspzz tmspzz deleted the rc_default_value_camera branch July 14, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants