fix: invalidate conversation members [WPB-3047] #1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garzas
requested review from
typfel,
MohamadJaara,
vitorhugods,
mchenani and
saleniuk
github-actions
bot
added
🚨 Potential breaking changes
👕 size: S
type: bug / fix 🐞
labels
persistence/src/commonMain/db_user/com/wire/kalium/persistence/Members.sq
Show resolved
Hide resolved
MohamadJaara
requested changes
Jul 13, 2023
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/conversation/ConversationRepository.kt
Show resolved
Hide resolved
...commonMain/kotlin/com/wire/kalium/logic/sync/receiver/conversation/MemberJoinEventHandler.kt
Show resolved
Hide resolved
persistence/src/commonMain/db_user/com/wire/kalium/persistence/Members.sq
Show resolved
Hide resolved
persistence/src/commonMain/kotlin/com/wire/kalium/persistence/dao/ConversationDAOImpl.kt
Outdated
Show resolved
Hide resolved
MohamadJaara
approved these changes
Jul 13, 2023
saleniuk
approved these changes
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
When user is leaving conversation, after that he will not receive any events about member leave or join that conversation. So after rejoining conversation he will have wrong conversation member list.
Also slow sync will not remove members who left when user was not a member of conversation, because slow sync only adds members.
Solutions
Because of potential performance problems I forced slow sync with entire members invalidation just once. In next version we can remove it and always invalidate conversation members when user will rejoin conversation