-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RC): send pings as self deleting and messsage duration clenup #1877
feat(RC): send pings as self deleting and messsage duration clenup #1877
Conversation
Codecov Report
@@ Coverage Diff @@
## release/candidate #1877 +/- ##
====================================================
Coverage ? 54.43%
Complexity ? 1525
====================================================
Files ? 969
Lines ? 35753
Branches ? 3182
====================================================
Hits ? 19462
Misses ? 15001
Partials ? 1290 |
@@ -685,22 +681,13 @@ internal class ConversationDataSource internal constructor( | |||
override suspend fun getConversationUnreadEventsCount(conversationId: ConversationId): Either<StorageFailure, Long> = | |||
wrapStorageRequest { messageDAO.getConversationUnreadEventsCount(conversationId.toDao()) } | |||
|
|||
override suspend fun getUserSelfDeletionTimer(conversationId: ConversationId): Either<StorageFailure, SelfDeletionTimer> = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this fun is not used anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had some concerns but reading the rest of the PR made it all clear to me.
Nicely done. Good choices.
...rc/commonMain/kotlin/com/wire/kalium/logic/feature/selfDeletingMessages/SelfDeletionTimer.kt
Show resolved
Hide resolved
...rc/commonMain/kotlin/com/wire/kalium/logic/feature/selfDeletingMessages/SelfDeletionTimer.kt
Show resolved
Hide resolved
...logic/feature/selfDeletingMessages/ObserveSelfDeletionTimerSettingsForConversationUseCase.kt
Show resolved
Hide resolved
.../logic/util/arrangement/ObserveSelfDeletionTimerSettingsForConversationUseCaseArrangement.kt
Outdated
Show resolved
Hide resolved
…ment/ObserveSelfDeletionTimerSettingsForConversationUseCaseArrangement.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]>
…d_pings_as_self_deleting # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/ProtoContentMapper.kt
…1877) * feat: send self deleting knock messages * map knock to ephemeral message when sending * cleanup ephemeral message sending * detekt * detekt * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/util/arrangement/ObserveSelfDeletionTimerSettingsForConversationUseCaseArrangement.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * update test --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]>
* feat: add timer to all message types (#1870) * feat: add message timer to all message types * parse ephemeral pings from/to proto * feat: accept ephemeral system message * detekt * detekt * fix test * address PR comments * address PR comments * merge conflicts * feat(RC): send pings as self deleting and messsage duration clenup (#1877) * feat: send self deleting knock messages * map knock to ephemeral message when sending * cleanup ephemeral message sending * detekt * detekt * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/util/arrangement/ObserveSelfDeletionTimerSettingsForConversationUseCaseArrangement.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * update test --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> * fix mapper --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]>
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
pings are not sent as self deleting
Solutions
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.