Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add logs for reset session #1876

Merged
merged 2 commits into from
Jul 11, 2023
Merged

chore: add logs for reset session #1876

merged 2 commits into from
Jul 11, 2023

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Adding some logs to help QA investigation about some test failures related to reset session.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023

Unit Test Results

   285 files   - 108     285 suites   - 108   11s ⏱️ - 1m 31s
1 459 tests  - 633  1 426 ✔️  - 579  33 💤  - 54  0 ±0 

Results for commit 0e7c9b4. ± Comparison against base commit cbb39af.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

Merging #1876 (bec0f23) into develop (1aabb47) will increase coverage by 0.01%.
The diff coverage is 75.00%.

@@              Coverage Diff              @@
##             develop    #1876      +/-   ##
=============================================
+ Coverage      54.62%   54.63%   +0.01%     
  Complexity      1625     1625              
=============================================
  Files           1006     1006              
  Lines          36862    36868       +6     
  Branches        3301     3301              
=============================================
+ Hits           20135    20142       +7     
  Misses         15367    15367              
+ Partials        1360     1359       -1     
Impacted Files Coverage Δ
.../kalium/logic/feature/debug/BreakSessionUseCase.kt 0.00% <0.00%> (ø)
.../logic/feature/sessionreset/ResetSessionUseCase.kt 97.05% <100.00%> (+0.39%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbb39af...bec0f23. Read the comment docs.

@ohassine ohassine enabled auto-merge (squash) July 11, 2023 14:03
@ohassine ohassine merged commit 3282688 into develop Jul 11, 2023
9 checks passed
@ohassine ohassine deleted the add_logs_reset_session branch July 11, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants