Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Not receiving messages after deleting conversation (WPB-3040) (RC) #1873

Conversation

ohassine
Copy link
Member


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

Same PR as #1872 for RC branch


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@ohassine ohassine requested review from vitorhugods, typfel and MohamadJaara and removed request for vitorhugods July 10, 2023 16:07
@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023

Unit Test Results

       6 files         6 suites   6m 47s ⏱️
1 926 tests 1 912 ✔️ 14 💤 0

Results for commit a13357e.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release/candidate@25f08d1). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                  @@
##             release/candidate    #1873   +/-   ##
====================================================
  Coverage                     ?   54.49%           
  Complexity                   ?     1531           
====================================================
  Files                        ?      969           
  Lines                        ?    35758           
  Branches                     ?     3179           
====================================================
  Hits                         ?    19486           
  Misses                       ?    14977           
  Partials                     ?     1295           

@ohassine ohassine requested review from a team, yamilmedina, saleniuk and alexandreferris and removed request for a team July 11, 2023 07:29
@ohassine ohassine merged commit 57ed185 into release/candidate Jul 11, 2023
9 checks passed
@ohassine ohassine deleted the rc_not_receiving_messages_after_deleting_conversation branch July 11, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants