feat: add timer to all message types #1870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## release/candidate #1870 +/- ##
====================================================
Coverage ? 54.39%
Complexity ? 1530
====================================================
Files ? 969
Lines ? 35810
Branches ? 3205
====================================================
Hits ? 19478
Misses ? 15036
Partials ? 1296 |
MohamadJaara
requested review from
a team,
typfel,
yamilmedina,
alexandreferris,
borichellow,
Garzas and
trOnk12
and removed request for
a team
Garzas
requested changes
Jul 11, 2023
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/ProtoContentMapper.kt
Show resolved
Hide resolved
...in/kotlin/com/wire/kalium/logic/feature/message/ephemeral/EphemeralMessageDeletionHandler.kt
Outdated
Show resolved
Hide resolved
| // Handle self-deleting Location messages when they are implemented | ||
| else -> { | ||
| is Ephemeral.Content.Image, |
There was a problem hiding this comment.
Should Image be ignored as well? 🤔
There was a problem hiding this comment.
not sure what image is in this case, it was ignored before and my assumption that it is some sort of old and deprecated message type, maybe @typfel knows more about it
There was a problem hiding this comment.
Indeed it was replaced by assets https://github.com/wireapp/generic-message-proto/blob/ff36abddb9d668709e0c793ddc8d034ebfafd8f9/proto/messages.proto#L29 7 years ago.
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/message/MessageSender.kt
Outdated
Show resolved
Hide resolved
alexandreferris
approved these changes
Jul 11, 2023
typfel
reviewed
Jul 11, 2023
logic/src/commonMain/kotlin/com/wire/kalium/logic/data/message/MessageMapper.kt
Show resolved
Hide resolved
typfel
approved these changes
Jul 11, 2023
Garzas
approved these changes
Jul 12, 2023
MohamadJaara
added a commit
that referenced
this pull request
Jul 13, 2023
* feat: add message timer to all message types * parse ephemeral pings from/to proto * feat: accept ephemeral system message * detekt * detekt * fix test * address PR comments * address PR comments
6 tasks
tmspzz
pushed a commit
that referenced
this pull request
Jul 13, 2023
* feat: add timer to all message types (#1870) * feat: add message timer to all message types * parse ephemeral pings from/to proto * feat: accept ephemeral system message * detekt * detekt * fix test * address PR comments * address PR comments * merge conflicts * feat(RC): send pings as self deleting and messsage duration clenup (#1877) * feat: send self deleting knock messages * map knock to ephemeral message when sending * cleanup ephemeral message sending * detekt * detekt * Update logic/src/commonTest/kotlin/com/wire/kalium/logic/util/arrangement/ObserveSelfDeletionTimerSettingsForConversationUseCaseArrangement.kt Co-authored-by: Vitor Hugo Schwaab <[email protected]> * update test --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]> * fix mapper --------- Co-authored-by: Vitor Hugo Schwaab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
atm message timer is only applicable to Text and Asset Messages.
Solutions
Dependencies (Optional)
If there are some other pull requests related to this one (e.g. new releases of frameworks), specify them here.
Needs releases with:
Testing
Test Coverage (Optional)
How to Test
Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.
Notes (Optional)
Specify here any other facts that you think are important for this issue.
Attachments (Optional)
Attachments like images, videos, etc. (drag and drop in the text box)
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.