Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(monkeys): establish connections between users [WPB-2855] #1860

Merged
merged 4 commits into from
Jul 12, 2023

Conversation

vitorhugods
Copy link
Member

@vitorhugods vitorhugods commented Jul 4, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

When testing federated monkeys, we need to establish connection between them in order to create conversations and make them interact.

Solutions

Grouping monkeys by backend, we can follow the approach:

  • Take each monkey of the first backend, send connection request to the rest
  • Take each monkey of the second backend, accept connections from the first backend, and send connection requests to the rest,
  • Take each monkey of the third backend, accept connections from the ones before, and send connection requests to the rest,

and so on.

This is done on the setup step, after logging in and registering clients.

Dependencies

Testing

Manually tested.


PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2023

Unit Test Results

   393 files  ±0     393 suites  ±0   2m 52s ⏱️ + 1m 13s
2 092 tests ±0  2 005 ✔️ ±0  87 💤 ±0  0 ±0 

Results for commit cc692d0. ± Comparison against base commit ff825bd.

♻️ This comment has been updated with latest results.

@augustocdias augustocdias force-pushed the feat/monkeys/establish-connections-between-users branch from 3f48378 to 1c22296 Compare July 6, 2023 15:46
@codecov-commenter
Copy link

Codecov Report

Merging #1860 (1c22296) into develop (a7472df) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             develop    #1860      +/-   ##
=============================================
- Coverage      54.11%   54.08%   -0.04%     
  Complexity      1618     1618              
=============================================
  Files           1005     1005              
  Lines          37010    37034      +24     
  Branches        3312     3317       +5     
=============================================
+ Hits           20027    20028       +1     
- Misses         15633    15656      +23     
  Partials        1350     1350              
Impacted Files Coverage Δ
...wire/kalium/monkeys/DefaultConversationCreation.kt 0.00% <0.00%> (ø)
...ain/kotlin/com/wire/kalium/monkeys/DefaultSetup.kt 0.00% <0.00%> (ø)
...otlin/com/wire/kalium/monkeys/MonkeyApplication.kt 0.00% <0.00%> (ø)
...ain/kotlin/com/wire/kalium/monkeys/TestSequence.kt 0.00% <ø> (ø)
...re/kalium/monkeys/command/BananaPerGroupCommand.kt 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7472df...1c22296. Read the comment docs.

@vitorhugods vitorhugods marked this pull request as ready for review July 7, 2023 07:39
Comment on lines +50 to +58
"api": "https://nginz-https.chala.wire.link",
"webSocket": "https://nginz-ssl.chala.wire.link",
"blackList": "https://clientblacklist.wire.com/staging",
"teams": "https://teams.chala.wire.link",
"accounts": "https://account.chala.wire.link",
"website": "https://wire.com",
"passwordForUsers": "Aqa123456!",
"domain": "chala.wire.link",
"title": "chala.wire.link",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vitorhugods vitorhugods enabled auto-merge (squash) July 12, 2023 13:24
@vitorhugods vitorhugods merged commit 83872af into develop Jul 12, 2023
9 checks passed
@vitorhugods vitorhugods deleted the feat/monkeys/establish-connections-between-users branch July 12, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants