-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(e2ei): add E2EIEnroll usecase (WPB-370) #1833
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…t/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…/e2ei/e2ei_usecase
…t/e2ei/e2ei_usecase
This reverts commit 377c137.
Codecov Report
@@ Coverage Diff @@
## develop #1833 +/- ##
=============================================
+ Coverage 54.63% 54.93% +0.29%
- Complexity 1626 1632 +6
=============================================
Files 1008 1011 +3
Lines 36931 37149 +218
Branches 3309 3313 +4
=============================================
+ Hits 20177 20406 +229
+ Misses 15394 15378 -16
- Partials 1360 1365 +5
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
typfel
requested changes
Jun 27, 2023
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/UserScope.kt
Outdated
Show resolved
Hide resolved
network/src/commonMain/kotlin/com/wire/kalium/network/api/base/unbound/acme/ACMEApi.kt
Show resolved
Hide resolved
cryptography/src/commonMain/kotlin/com/wire/kalium/cryptography/MLSClient.kt
Outdated
Show resolved
Hide resolved
typfel
reviewed
Jun 28, 2023
logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/UserScope.kt
Outdated
Show resolved
Hide resolved
typfel
approved these changes
Jun 28, 2023
typfel
changed the title
feat(e2ei): add E2EIEnrol usecase (WPB-370)
feat(e2ei): add E2EIEnroll usecase (WPB-370)
Jun 28, 2023
borichellow
approved these changes
Jun 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jun 28, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jun 28, 2023
…/e2ei/e2ei_usecase # Conflicts: # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/UserScope.kt
…/e2ei/e2ei_usecase # Conflicts: # cryptography/src/commonJvmAndroid/kotlin/com.wire.kalium.cryptography/MLSClientImpl.kt # cryptography/src/commonMain/kotlin/com/wire/kalium/cryptography/MLSClient.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt # logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/UserScope.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Add E2EI enrolment usecase.
Testing
Unit tests included.
Test Coverage (Optional)
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.