Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(e2ei): add E2EIEnroll usecase (WPB-370) #1833

Merged
merged 73 commits into from
Jul 18, 2023
Merged

Conversation

mchenani
Copy link
Member

@mchenani mchenani commented Jun 27, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Add E2EI enrolment usecase.

Testing

Unit tests included.

Test Coverage (Optional)

  • I have added automated test to this contribution

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

mchenani added 30 commits May 9, 2023 17:00
@github-actions
Copy link
Contributor

github-actions bot commented Jun 27, 2023

Unit Test Results

   401 files  +  7     401 suites  +7   2m 1s ⏱️ ±0s
2 164 tests +60  2 066 ✔️ +49  98 💤 +11  0 ±0 

Results for commit 0a8123b. ± Comparison against base commit 0979362.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented Jun 27, 2023

Codecov Report

Merging #1833 (90e8dd2) into develop (1a3db5f) will increase coverage by 0.29%.
The diff coverage is 70.03%.

@@              Coverage Diff              @@
##             develop    #1833      +/-   ##
=============================================
+ Coverage      54.63%   54.93%   +0.29%     
- Complexity      1626     1632       +6     
=============================================
  Files           1008     1011       +3     
  Lines          36931    37149     +218     
  Branches        3309     3313       +4     
=============================================
+ Hits           20177    20406     +229     
+ Misses         15394    15378      -16     
- Partials        1360     1365       +5     
Impacted Files Coverage Δ
.../kotlin/com/wire/kalium/cryptography/E2EIClient.kt 100.00% <ø> (+100.00%) ⬆️
.../kotlin/com/wire/kalium/logic/GlobalKaliumScope.kt 0.00% <0.00%> (ø)
...in/com/wire/kalium/logic/feature/user/UserScope.kt 0.00% <0.00%> (ø)
...ire/kalium/logic/data/client/E2EIClientProvider.kt 3.33% <3.33%> (ø)
...onMain/kotlin/com/wire/kalium/logic/CoreFailure.kt 18.69% <14.28%> (-0.31%) ⬇️
...eceiver/conversation/message/MLSMessageUnpacker.kt 56.62% <35.29%> (-4.71%) ⬇️
...monMain/kotlin/com/wire/kalium/cryptography/IDs.kt 68.96% <44.44%> (-11.04%) ⬇️
...gic/data/conversation/MLSConversationRepository.kt 83.45% <66.66%> (-0.25%) ⬇️
...re/kalium/network/api/base/unbound/acme/ACMEApi.kt 51.85% <75.00%> (+51.85%) ⬆️
.../com/wire/kalium/logic/data/e2ei/E2EIRepository.kt 81.48% <81.48%> (ø)
... and 4 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a3db5f...90e8dd2. Read the comment docs.

@typfel typfel changed the title feat(e2ei): add E2EIEnrol usecase (WPB-370) feat(e2ei): add E2EIEnroll usecase (WPB-370) Jun 28, 2023
@mchenani mchenani added this pull request to the merge queue Jun 28, 2023
@mchenani mchenani removed this pull request from the merge queue due to a manual request Jun 28, 2023
@mchenani mchenani added this pull request to the merge queue Jun 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 28, 2023
@mchenani mchenani added this pull request to the merge queue Jun 28, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 28, 2023
@mchenani mchenani added this pull request to the merge queue Jun 28, 2023
@mchenani mchenani removed this pull request from the merge queue due to a manual request Jun 28, 2023
…/e2ei/e2ei_usecase

# Conflicts:
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/UserScope.kt
…/e2ei/e2ei_usecase

# Conflicts:
#	cryptography/src/commonJvmAndroid/kotlin/com.wire.kalium.cryptography/MLSClientImpl.kt
#	cryptography/src/commonMain/kotlin/com/wire/kalium/cryptography/MLSClient.kt
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/UserSessionScope.kt
#	logic/src/commonMain/kotlin/com/wire/kalium/logic/feature/user/UserScope.kt
@mchenani mchenani enabled auto-merge (squash) July 18, 2023 05:04
@mchenani mchenani merged commit 5f13458 into develop Jul 18, 2023
9 checks passed
@mchenani mchenani deleted the feat/e2ei/e2ei_usecase branch July 18, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants