-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use new API for setting epoch secret WPB-261 #1752
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1752 +/- ##
==========================================
Coverage 54.62% 54.62%
Complexity 1625 1625
==========================================
Files 1006 1006
Lines 36862 36862
Branches 3301 3301
==========================================
+ Hits 20135 20136 +1
Misses 15367 15367
+ Partials 1360 1359 -1
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
MohamadJaara
approved these changes
May 23, 2023
ohassine
approved these changes
May 30, 2023
typfel
force-pushed
the
fix/no-audio-with-web-mls-conference
branch
from
June 2, 2023 09:01
c9ff31a
to
aed0da0
Compare
typfel
changed the title
fix: no audio in MLS conferences with web FS-1975
chore: use new API for setting epoch secret in MLS conf calls WPB-261
Jun 2, 2023
typfel
force-pushed
the
fix/no-audio-with-web-mls-conference
branch
from
June 2, 2023 15:48
aed0da0
to
63fec19
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Jun 20, 2023
typfel
changed the title
chore: use new API for setting epoch secret in MLS conf calls WPB-261
chore: use new API for setting epoch secret WPB-261
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764
The PR Description
What's new in this PR?
Issues
No audio in MLS conferences between Web & Android
Causes
Web base64 encodes the epoch secret they give to AVS
Solutions
Align with Web by base64 encoding the epoch secret
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.