Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use new API for setting epoch secret WPB-261 #1752

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

typfel
Copy link
Member

@typfel typfel commented May 22, 2023


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

No audio in MLS conferences between Web & Android

Causes

Web base64 encodes the epoch secret they give to AVS

Solutions

Align with Web by base64 encoding the epoch secret


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2023

Unit Test Results

   285 files   - 108     285 suites   - 108   11s ⏱️ - 2m 3s
1 459 tests  - 633  1 426 ✔️  - 579  33 💤  - 54  0 ±0 

Results for commit 3f1898f. ± Comparison against base commit 1aabb47.

♻️ This comment has been updated with latest results.

@codecov-commenter
Copy link

codecov-commenter commented May 22, 2023

Codecov Report

Merging #1752 (3f1898f) into develop (1aabb47) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #1752   +/-   ##
==========================================
  Coverage      54.62%   54.62%           
  Complexity      1625     1625           
==========================================
  Files           1006     1006           
  Lines          36862    36862           
  Branches        3301     3301           
==========================================
+ Hits           20135    20136    +1     
  Misses         15367    15367           
+ Partials        1360     1359    -1     
Impacted Files Coverage Δ
...mAndroid/kotlin/com.wire.kalium.calling/Calling.kt 0.00% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aabb47...3f1898f. Read the comment docs.

@typfel typfel force-pushed the fix/no-audio-with-web-mls-conference branch from c9ff31a to aed0da0 Compare June 2, 2023 09:01
@typfel typfel changed the title fix: no audio in MLS conferences with web FS-1975 chore: use new API for setting epoch secret in MLS conf calls WPB-261 Jun 2, 2023
@typfel typfel force-pushed the fix/no-audio-with-web-mls-conference branch from aed0da0 to 63fec19 Compare June 2, 2023 15:48
@typfel typfel enabled auto-merge June 20, 2023 07:09
@typfel typfel added this pull request to the merge queue Jun 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jun 20, 2023
@typfel typfel changed the title chore: use new API for setting epoch secret in MLS conf calls WPB-261 chore: use new API for setting epoch secret WPB-261 Jul 11, 2023
@typfel typfel merged commit ff825bd into develop Jul 11, 2023
10 of 11 checks passed
@typfel typfel deleted the fix/no-audio-with-web-mls-conference branch July 11, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants