test: remove --timeout and fix disabling throttling (#656)

see probot/probot#1972 (comment)
wip · Feb 10, 2024 · bc3d1bf · bc3d1bf
1 parent 70b9da8
commit bc3d1bf
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 17 deletions.
diff --git a/package.json b/package.json
@@ -6,7 +6,7 @@
   "main": "index.js",
   "scripts": {
     "start": "probot run ./index.js",
-    "test": "tap test/**/*-test.js --timeout 240",
+    "test": "tap test/**/*-test.js",
     "posttest": "npm run lint",
     "coverage-report": "npx tap report --coverage-report lcov",
     "lint": "prettier --check '{lib,test}/**/*.{js,json,ts}' index.js *.md package.json",

diff --git a/test/integration/free-plan-test.js b/test/integration/free-plan-test.js
@@ -31,10 +31,13 @@ beforeEach(async () => {
   probot = new Probot({
     id: 1,
     githubToken: "test",
-    Octokit: ProbotOctokit.defaults({
-      throttle: { enabled: false },
-      retry: { enabled: false },
-      log: pino(streamLogsToOutput),
+    Octokit: ProbotOctokit.defaults((instanceOptions) => {
+      return {
+        ...instanceOptions,
+        throttle: { enabled: false },
+        retry: { enabled: false },
+        log: pino(streamLogsToOutput),
+      };
     }),
     log: pino(streamLogsToOutput),
   });

diff --git a/test/integration/installation-test.js b/test/integration/installation-test.js
@@ -30,10 +30,13 @@ beforeEach(function () {
   probot = new Probot({
     id: 1,
     githubToken: "test",
-    Octokit: ProbotOctokit.defaults({
-      throttle: { enabled: false },
-      retry: { enabled: false },
-      log: pino(streamLogsToOutput),
+    Octokit: ProbotOctokit.defaults((instanceOptions) => {
+      return {
+        ...instanceOptions,
+        throttle: { enabled: false },
+        retry: { enabled: false },
+        log: pino(streamLogsToOutput),
+      };
     }),
     log: pino(streamLogsToOutput),
   });

diff --git a/test/integration/marketplace-purchase-test.js b/test/integration/marketplace-purchase-test.js
@@ -30,10 +30,13 @@ beforeEach(function () {
   probot = new Probot({
     id: 1,
     githubToken: "test",
-    Octokit: ProbotOctokit.defaults({
-      throttle: { enabled: false },
-      retry: { enabled: false },
-      log: pino(streamLogsToOutput),
+    Octokit: ProbotOctokit.defaults((instanceOptions) => {
+      return {
+        ...instanceOptions,
+        throttle: { enabled: false },
+        retry: { enabled: false },
+        log: pino(streamLogsToOutput),
+      };
     }),
     log: pino(streamLogsToOutput),
   });

diff --git a/test/integration/pro-plan-test.js b/test/integration/pro-plan-test.js
@@ -30,10 +30,13 @@ beforeEach(function () {
   probot = new Probot({
     id: 1,
     githubToken: "test",
-    Octokit: ProbotOctokit.defaults({
-      throttle: { enabled: false },
-      retry: { enabled: false },
-      log: pino(streamLogsToOutput),
+    Octokit: ProbotOctokit.defaults((instanceOptions) => {
+      return {
+        ...instanceOptions,
+        throttle: { enabled: false },
+        retry: { enabled: false },
+        log: pino(streamLogsToOutput),
+      };
     }),
     log: pino(streamLogsToOutput),
   });