add nires #781
Open
add nires #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8075034550Details
💛 - Coveralls |
robertdstein
requested changes
Feb 28, 2024
|
|
||
| class UkidssGPS(VizierCatalog): | ||
| """ | ||
| UKIDSS GPS catalog |
There was a problem hiding this comment.
Can you maybe add e.g an arxiv link somewhere to explain what this catalog is?
| @@ -0,0 +1,20 @@ | |||
| """ | |||
| This file contains the configuration for the winter pipeline. | |||
|
|
||
| def nires_astrometric_ref_catalog_generator(_) -> UkidssGPS: | ||
| """ | ||
| Generates the astrometric reference catalog for the NIRES image |
There was a problem hiding this comment.
returns? Mention UkiddsGps
| header[GAIN_KEY] = 1.0 | ||
| header["FILTER"] = "ks" | ||
|
|
||
| # header[SNCOSMO_KEY] = sncosmo_filters[header["FILTER"].lower()] |
| # header["DATE-OBS"] = header["UTSHUT"] | ||
| header["MJD-OBS"] = Time(header["DATE-OBS"]).mjd | ||
|
|
||
| # header.remove("CRVAL1") |
| if "PROGID" not in header.keys(): | ||
| header["PROGID"] = 0 | ||
|
|
||
| if "v240225_0012.fits" in path.as_posix(): |
There was a problem hiding this comment.
What is this stuff? Is it needed for the PR?
|
|
||
| def load_raw_nires_image(path: str | Path) -> Image: | ||
| """ | ||
| Function to load a raw GIT image |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.