set activate workspace in .wmill/activeWorkspace in workspace directory

[wenbinye]

Set activate workspace in .wmill/activeWorkspace in workspace directory by command
wmill workspace switch <workspace>
The workspace activate when switch to the directory automatic.

---

Important

Prioritize setting and getting active workspace from .wmill/activeWorkspace in workspace.ts, with fallback to global store.

• Behavior:
  • getActiveWorkspaceName() now prioritizes reading from .wmill/activeWorkspace before falling back to the global store.
  • setActiveWorkspace() writes to .wmill/activeWorkspace if .wmill directory exists, otherwise writes to global store.
• Functions:
  • Modifies getActiveWorkspaceName() and setActiveWorkspace() in workspace.ts to handle local and global workspace activation.
• Logging:
  • Logs a message if .wmill directory is not found when setting active workspace.

^{This description was created by for cbd81f9. It will automatically update as commits are pushed.}

[github-actions]

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

---

I have read the CLA Document and I hereby sign the CLA

---

_{You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to cbd81f9 in 17 seconds

More details

• Looked at 35 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 3 drafted comments based on config settings.

1. cli/workspace.ts:128

• Draft comment:
  Consider using Deno.lstatSync instead of Deno.statSync to check if '.wmill' is a directory. lstatSync is more appropriate for checking the existence of a directory or file.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code attempts to check if '.wmill' is a directory using Deno.statSync, which can throw an error if the directory does not exist. This is correctly handled by the try-catch block, but the logic can be improved by using Deno.lstatSync, which is more appropriate for checking the existence of a directory or file.

2. cli/workspace.ts:43

• Draft comment:
  Consider handling the case where the '.wmill/activeWorkspace' file might be empty, which could lead to unexpected behavior.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code uses Deno.readTextFile to read the active workspace file. However, it does not handle the case where the file might be empty, which could lead to unexpected behavior. Adding a check for an empty file would improve robustness.

3. cli/workspace.ts:46

• Draft comment:
  Consider handling the case where the 'activeWorkspace' file might be empty, which could lead to unexpected behavior. This is also applicable in the previous Deno.readTextFile call.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The code uses Deno.readTextFile to read the active workspace file. However, it does not handle the case where the file might be empty, which could lead to unexpected behavior. Adding a check for an empty file would improve robustness. This is applicable in both places where Deno.readTextFile is used for reading the active workspace.

Workflow ID: wflow_w9qg5BOXAnbagP4e

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[rubenfiszel]

Thanks for the contribution.

It's a nice idea and I did want to do it too. It's lacking a bit of discovery and relying on the existence or not of .wmill which I'm not a fan.

I suggest to have an option: --persist-in-folder to the switch command that will indeed write there (and create dir if necessary) but otherwise it's not written there. So it is used by default only if .wmill/activeInstance in which case a log mention that it is used and how to override it or delete it.

When it's not used because it doesn't exist, a log mention that it's using the global setting because no .wmill/activeInstance was found

[graphite-app]

The isDirectory property is actually a method that needs to be invoked with parentheses. This line should be:

if (Deno.statSync('.wmill').isDirectory()) {

Without the parentheses, the condition will evaluate to truthy whenever the method exists on the object, regardless of whether the path is actually a directory.

Suggested change

	if (Deno.statSync('.wmill').isDirectory) {
	if (Deno.statSync('.wmill').isDirectory()) {

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.