Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: queue v2 migration steps #5029

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

backend: queue v2 migration steps #5029

wants to merge 6 commits into from
+9,499 −1,627

Conversation

uael
Copy link
Collaborator

@uael uael commented Jan 8, 2025 •
edited
Loading

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jan 8, 2025 •
edited
Loading

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 39378d7
Status: ✅  Deploy successful!
Preview URL: https://cb564d25.windmill.pages.dev
Branch Preview URL: https://uael-queue-v2.windmill.pages.dev

View logs

@uael

This comment has been minimized.

Sign in to view
@uael

This comment has been minimized.

Sign in to view
@uael uael force-pushed the uael/queue_v2 branch 7 times, most recently from e9fd910 to bbaacd8 Compare January 14, 2025 08:42
HugoCasa
HugoCasa reviewed Jan 15, 2025
View reviewed changes
Copy link
Contributor

@HugoCasa HugoCasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • add metadata field?
  • just wondering if there is a better alternative than checking pg_trigger_depth

backend/migrations/20250110124431_v2_job.up.sql Outdated Show resolved Hide resolved
backend/migrations/20250110124431_v2_job.up.sql Outdated Show resolved Hide resolved
@uael
Copy link
Collaborator Author

uael commented Jan 15, 2025

  • add metadata field?

  • just wondering if there is a better alternative than checking pg_trigger_depth

There is but slightly more complex, I go for the simplest one since they are only temporary triggers. WDYT ?

@HugoCasa
Copy link
Contributor

yes i guess as it's temporary it's not worth doing more complex

@uael uael force-pushed the uael/queue_v2 branch 2 times, most recently from b545ff3 to ca48042 Compare January 16, 2025 15:58
uael
uael commented Jan 17, 2025
View reviewed changes
Copy link
Collaborator Author

@uael uael left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Keep completed job deleted column

backend/migrations/20250110124743_v2_job_queue_sync.up.sql Show resolved Hide resolved
backend/migrations/20250110124744_v2_job_completed_sync.up.sql Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HugoCasa HugoCasa HugoCasa left review comments

@rubenfiszel rubenfiszel Awaiting requested review from rubenfiszel rubenfiszel will be requested when the pull request is marked ready for review rubenfiszel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uael @HugoCasa