websocket killpill

[HugoCasa]

Important

Adds a 'killpill' mechanism to terminate websocket listeners in websocket_triggers.rs.

• Behavior:
  • Introduces killpill_rx to stop websocket listeners in start_websockets, listen_to_unlistened_websockets, maybe_listen_to_websocket, and listen_to_websocket.
  • Uses tokio::select! to listen for killpill_rx signal and terminate loops in start_websockets and listen_to_websocket.
• Functions:
  • Refactors start_websockets to use listen_to_unlistened_websockets for initial websocket setup.
  • Adds killpill_rx parameter to maybe_listen_to_websocket and listen_to_websocket to handle termination.
• Misc:
  • Minor refactoring to improve code readability and maintainability.

^{This description was created by for 804dbe4. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 804dbe4 in 19 seconds

More details

• Looked at 274 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 4 drafted comments based on config settings.

1. backend/windmill-api/src/websocket_triggers.rs:333

• Draft comment:
  Redundant return type -> () in function signature. Consider removing it for clarity and conciseness.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The function signature should not include '-> ()' as it is redundant in Rust for functions returning '()'.

2. backend/windmill-api/src/websocket_triggers.rs:359

• Draft comment:
  Redundant return type -> () in function signature. Consider removing it for clarity and conciseness.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The function signature should not include '-> ()' as it is redundant in Rust for functions returning '()'.

3. backend/windmill-api/src/websocket_triggers.rs:474

• Draft comment:
  Redundant return type -> () in function signature. Consider removing it for clarity and conciseness.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The function signature should not include '-> ()' as it is redundant in Rust for functions returning '()'.

4. backend/windmill-api/src/websocket_triggers.rs:595

• Draft comment:
  Typo in error message: "Websocket cloesd" should be "Websocket closed".
• Reason this comment was not posted:
  Confidence changes required: 50%
  The error message contains a typo 'cloesd' which should be 'closed'.

Workflow ID: wflow_POg78DZxjN9Pcvs2

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.