Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support colon in job filter tags scope #4549

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

HugoCasa
Copy link
Contributor

@HugoCasa HugoCasa commented Oct 18, 2024

Important

Update get_scope_tags in users.rs to support scope tags with colons by simplifying the logic.

  • Functionality:
    • Update get_scope_tags in users.rs to support scope tags with colons by checking if the string starts with if_jobs:filter_tags: and then splitting the remaining part by commas.
  • Code Simplification:
    • Simplified the logic in get_scope_tags by using starts_with and trim_start_matches instead of pattern matching with split.

This description was created by Ellipsis for 8693277. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 8693277 in 14 seconds

More details
  • Looked at 30 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. backend/windmill-api/src/users.rs:708
  • Draft comment:
    The refactored code improves performance by avoiding unnecessary allocations. The use of starts_with and trim_start_matches is more efficient than splitting the string and collecting it into a vector.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The refactored code improves readability and performance by avoiding unnecessary allocations. The use of starts_with and trim_start_matches is more efficient than splitting the string and collecting it into a vector.

Workflow ID: wflow_DaBnqArqPhzyARKj


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8693277
Status: ✅  Deploy successful!
Preview URL: https://7dcd75be.windmill.pages.dev
Branch Preview URL: https://hugo-win-453-tags-if-filter.windmill.pages.dev

View logs

@rubenfiszel rubenfiszel merged commit 9b4e7be into main Oct 18, 2024
3 checks passed
@rubenfiszel rubenfiszel deleted the hugo/win-453-tags-if-filter-support-in-tags branch October 18, 2024 18:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants