support colon in job filter tags scope #4549
Merged
+11
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Update
get_scope_tags
inusers.rs
to support scope tags with colons by simplifying the logic.get_scope_tags
inusers.rs
to support scope tags with colons by checking if the string starts withif_jobs:filter_tags:
and then splitting the remaining part by commas.get_scope_tags
by usingstarts_with
andtrim_start_matches
instead of pattern matching withsplit
.This description was created by for 8693277. It will automatically update as commits are pushed.