Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove debug line #4548

Merged
merged 2 commits into from
Oct 18, 2024
Merged

remove debug line #4548

merged 2 commits into from
Oct 18, 2024

Conversation

wendrul
Copy link
Contributor

@wendrul wendrul commented Oct 18, 2024

Important

Remove debug logging lines from get_logs_from_store() in jobs.rs.

  • Logging:
    • Remove debug logging lines in get_logs_from_store() in jobs.rs related to object store client presence and file retrieval.

This description was created by Ellipsis for 76a70f8. It will automatically update as commits are pushed.

@wendrul wendrul changed the title Remove debug line remove debug line Oct 18, 2024
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to aae6732 in 18 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_shsMtAr2zzYSrkMK


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@wendrul wendrul marked this pull request as draft October 18, 2024 15:45
Copy link

cloudflare-workers-and-pages bot commented Oct 18, 2024

Deploying windmill with  Cloudflare Pages  Cloudflare Pages

Latest commit: 76a70f8
Status: ✅  Deploy successful!
Preview URL: https://1003a358.windmill.pages.dev
Branch Preview URL: https://win-491-remove-useless-debug.windmill.pages.dev

View logs

@wendrul wendrul marked this pull request as ready for review October 18, 2024 16:58
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 76a70f8 in 7 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_OxJf58cMZMF1z6H4


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@rubenfiszel rubenfiszel merged commit eb5ad0e into main Oct 18, 2024
3 checks passed
@rubenfiszel rubenfiszel deleted the win-491-remove-useless-debug-line branch October 18, 2024 18:31
@github-actions github-actions bot locked and limited conversation to collaborators Oct 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants