-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migration/queue params #4487
base: main
Are you sure you want to change the base?
Migration/queue params #4487
Conversation
…on first git clone
…le-checked. some types "masking" and a better alternative to some 'select * from queue'
…tion/queue-params
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 0 out of 2 committers have signed the CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 6411de2 in 31 seconds
More details
- Looked at
1762
lines of code in25
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/.gitignore:13
- Draft comment:
The use of!build/.gitkeep
is unnecessary unless you have a specific reason to keep an empty directory in the repository. Consider removing it if not needed. - Reason this comment was not posted:
Confidence changes required:50%
The .gitignore file is generally fine, but the use of '!build/.gitkeep' is unnecessary if the intention is to keep the build directory tracked. This line is used to ensure the directory is not ignored, but it should be used only if there's a specific reason to keep an empty directory in the repository.
Workflow ID: wflow_BqpfMfuNf7mvTa23
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
c7e985c
to
8867260
Compare
4909207
to
59a1e67
Compare
Important
This pull request adds new database tables for job parameters, refactors job handling code, and introduces macros for database query fallbacks.
job_params
,job_args
, andcompleted_jobs_result
tables with corresponding up and down SQL scripts.job_params
table to includeworkspace_id
and removeargs
column.tag
column tojob_params
table.monitor.rs
to handle job cancellation with new parameters.inputs.rs
to usequery_scalar_with_fallback!
for fetching job arguments.jobs.rs
to handle job cancellation and result storage incompleted_jobs_result
.worker_flow.rs
to usefetch_one_with_fallback!
andfetch_optional_with_fallback!
macros for database queries.macros.rs
withfetch_one_with_fallback!
andfetch_optional_with_fallback!
macros for database query fallbacks.FlowStatusGetter
andFlowValueGetter
traits inflow_status.rs
andflows.rs
.const_format
dependency inCargo.toml
for string formatting in macros..gitignore
to include!build/.gitkeep
.This description was created by for 6411de2. It will automatically update as commits are pushed.