Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration/queue params #4487

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

yacineb
Copy link

@yacineb yacineb commented Oct 4, 2024

Important

This pull request adds new database tables for job parameters, refactors job handling code, and introduces macros for database query fallbacks.

  • Database Migrations:
    • Add job_params, job_args, and completed_jobs_result tables with corresponding up and down SQL scripts.
    • Modify job_params table to include workspace_id and remove args column.
    • Add tag column to job_params table.
  • Code Refactoring:
    • Update monitor.rs to handle job cancellation with new parameters.
    • Refactor inputs.rs to use query_scalar_with_fallback! for fetching job arguments.
    • Modify jobs.rs to handle job cancellation and result storage in completed_jobs_result.
    • Refactor worker_flow.rs to use fetch_one_with_fallback! and fetch_optional_with_fallback! macros for database queries.
  • Macros and Utilities:
    • Add macros.rs with fetch_one_with_fallback! and fetch_optional_with_fallback! macros for database query fallbacks.
    • Implement FlowStatusGetter and FlowValueGetter traits in flow_status.rs and flows.rs.
  • Miscellaneous:
    • Add const_format dependency in Cargo.toml for string formatting in macros.
    • Update .gitignore to include !build/.gitkeep.

This description was created by Ellipsis for 6411de2. It will automatically update as commits are pushed.

Copy link
Contributor

github-actions bot commented Oct 4, 2024

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


0 out of 2 committers have signed the CLA.
@yacine Bouraroui
@yacineb
yacine Bouraroui seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 6411de2 in 31 seconds

More details
  • Looked at 1762 lines of code in 25 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/.gitignore:13
  • Draft comment:
    The use of !build/.gitkeep is unnecessary unless you have a specific reason to keep an empty directory in the repository. Consider removing it if not needed.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The .gitignore file is generally fine, but the use of '!build/.gitkeep' is unnecessary if the intention is to keep the build directory tracked. This line is used to ensure the directory is not ignored, but it should be used only if there's a specific reason to keep an empty directory in the repository.

Workflow ID: wflow_BqpfMfuNf7mvTa23


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant