fix ws killpill (#4551)

* websocket killpill * oups * nit --------- Co-authored-by: Ruben Fiszel <[email protected]>
windmill-labs · Oct 18, 2024 · 17d9541 · 17d9541
1 parent fc7bbb9
commit 17d9541
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/...6f233ce478086430d8070fe7b2b8a4f9580e.json → ...1a50a832e65c8c9632e2e12cd9c2747f2fc7.json b/...6f233ce478086430d8070fe7b2b8a4f9580e.json → ...1a50a832e65c8c9632e2e12cd9c2747f2fc7.json
diff --git a/backend/windmill-api/src/lib.rs b/backend/windmill-api/src/lib.rs
@@ -247,7 +247,8 @@ pub async fn run_server(
     };
 
     if !*CLOUD_HOSTED {
-        websocket_triggers::start_websockets(db.clone(), rsmq).await;
+        let ws_killpill_rx = rx.resubscribe();
+        websocket_triggers::start_websockets(db.clone(), rsmq, ws_killpill_rx).await;
     }
 
     // build our application with a route

diff --git a/backend/windmill-api/src/websocket_triggers.rs b/backend/windmill-api/src/websocket_triggers.rs
@@ -592,7 +592,7 @@ async fn listen_to_websocket(
                                     } else {
                                         tracing::error!("Websocket {} closed", url);
                                         if let None =
-                                            update_ping(db.clone(), &ws_trigger, Some("Websocket cloesd")).await
+                                            update_ping(db.clone(), &ws_trigger, Some("Websocket closed")).await
                                         {
                                             return;
                                         }