Make compatible with ansible-lint >= 4.3.1 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version renamed and moved default_rulesdir and RulesCollection and removed the create_from_directory() class method of the latter. Signed-off-by: Nils Philippsen <[email protected]>
|
Noticed there are a few things missing which I've fixed locally but first want to test. |
nphilipp
force-pushed
the
master--default-rulesdir-constant
branch
from
70ca562
to
1246ca3
Compare
|
@nphilipp just wondering if this PR is ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of ansible-lint replaced ansiblelint.default_rulesdir with
ansiblelint.constants.DEFAULT_RULESDIR.
This obviates the need to pin the version of ansible-lint (see PR #92).