feat: optimize normal store setState mechanism 🎢 (#99)

willnguyen1312 · May 16, 2023 · 2768637 · 2768637
1 parent 32a1ea9
commit 2768637
Show file tree

Hide file tree

Showing 4 changed files with 24 additions and 10 deletions.
diff --git a/.changeset/eleven-spiders-chew.md b/.changeset/eleven-spiders-chew.md
@@ -0,0 +1,5 @@
+---
+"@zoom-image/core": minor
+---
+
+optimize normal store setState mechanism 🎢
diff --git a/.changeset/good-dogs-think.md b/.changeset/good-dogs-think.md
@@ -0,0 +1,5 @@
+---
+"@zoom-image/core": minor
+---
+
+Optimize rendering mechanism 🚀
diff --git a/packages/core/src/store.ts b/packages/core/src/store.ts
@@ -7,7 +7,7 @@ export function createStore<TState>(initialState: TState) {
   let prevState: TState | undefined
 
   const setState = (updatedState: Partial<TState>) => {
-    if (batching && !prevState) {
+    if (!prevState) {
       prevState = { ...state }
     }
 
@@ -20,16 +20,14 @@ export function createStore<TState>(initialState: TState) {
   const flush = () => {
     if (batching) return
 
-    if (!prevState) {
-      listeners.forEach((listener) => listener(state))
-      return
-    }
-
     let hasChanged = false
-    for (const key in state) {
-      if (state[key] !== prevState[key]) {
-        hasChanged = true
-        break
+
+    if (prevState) {
+      for (const key in state) {
+        if (state[key] !== prevState[key]) {
+          hasChanged = true
+          break
+        }
       }
     }
 

diff --git a/packages/core/test/store.test.ts b/packages/core/test/store.test.ts
@@ -15,6 +15,12 @@ describe("simple store", () => {
     expect(listener1).toHaveBeenCalledTimes(1)
     expect(listener2).toHaveBeenCalledTimes(1)
 
+    store.setState({ count: 1 })
+    store.setState({ count: 1 })
+    store.setState({ count: 1 })
+    expect(listener1).toHaveBeenCalledTimes(1)
+    expect(listener2).toHaveBeenCalledTimes(1)
+
     unsubscribe()
     store.setState({ count: 2 })
     expect(store.getState()).toEqual({ count: 2 })