Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFCORE-7143] Consolidate HostControllerBootstrap and EmbeddedHostCon… #6325

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

bstansberry
Copy link
Contributor

@bstansberry
Copy link
Contributor Author

@yersan @luck3y @jamezp FYI.

@jamezp
Copy link
Member

jamezp commented Jan 21, 2025

The failure seems like it might be related.

Copy link
Contributor

@luck3y luck3y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it should be fine to me, don't see anything obvious :)

@wildfly-ci

This comment was marked as outdated.

@bstansberry
Copy link
Contributor Author

The failure seems like it might be related.

@jamezp This PR only touches host controller code and none of the failures are in tests running a domain; they are use standalone servers. They all fail intermittently.

@bstansberry bstansberry added the hold Do not merge this PR label Jan 22, 2025
@bstansberry
Copy link
Contributor Author

I put the 'hold' label on this as I just realized the existing HostControllerBootstrap doesn't have a try/catch block in bootstrap. That's only in EmbeddedHostControllerBootstrap. So I'll need to fix that.

@bstansberry bstansberry removed the hold Do not merge this PR label Jan 29, 2025
@bstansberry
Copy link
Contributor Author

I fixed that so this is ready to go.

…trollerBootstrap
@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Jan 30, 2025
@yersan yersan merged commit 247c4c5 into wildfly:main Jan 30, 2025
12 of 13 checks passed
@yersan
Copy link
Collaborator

yersan commented Jan 30, 2025

Thanks @bstansberry @jamezp @luck3y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants