Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WFCORE-7112] Deprecate PermissionsParser.parse that takes ModuleIden… #6299

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[WFCORE-7112] Deprecate PermissionsParser.parse that takes ModuleIden… #6299

merged 1 commit into from
Dec 23, 2024

Conversation

bstansberry
Copy link
Contributor

@bstansberry bstansberry mentioned this pull request Dec 22, 2024
Merged
@wildfly-ci
Copy link

Core -> Full Integration Build 14467 outcome was UNKNOWN using a merge of 9e59bf1
Summary: Canceled (Tests passed: 5324, ignored: 62; Step 5/6) Build time: 02:52:28

@wildfly-ci
Copy link

Core -> Full Integration Build 14471 outcome was UNKNOWN using a merge of 9e59bf1
Summary: Canceled (Step 3/6) Build time: 00:01:41

@wildfly-ci

This comment was marked as off-topic.

Sign in to view
@wildfly-ci
Copy link

Core -> Full Integration Build 14472 outcome was UNKNOWN using a merge of 9e59bf1
Summary: Canceled (Step 5/6) Build time: 00:04:42

@wildfly-ci
Copy link

Core -> Full Integration Build 14474 outcome was UNKNOWN using a merge of 9e59bf1
Summary: Canceled (Step 3/6) Build time: 00:04:50

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 14252 outcome was UNKNOWN using a merge of 9e59bf1
Summary: Canceled (Step 5/6) Build time: 00:12:07

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 14253 outcome was UNKNOWN using a merge of 9e59bf1
Summary: Canceled Build time: 00:03:32

@wildfly-ci
Copy link

Core -> WildFly Preview Integration Build 14254 outcome was UNKNOWN using a merge of 9e59bf1
Summary: Canceled (Step 2/6) Build time: 00:04:41

yersan
yersan approved these changes Dec 23, 2024
View reviewed changes
.../main/java/org/wildfly/extension/security/manager/deployment/PermissionsParserProcessor.java
@@ -75,7 +74,7 @@ public void deploy(final DeploymentPhaseContext phaseContext) throws DeploymentU
final ResourceRoot deploymentRoot = deploymentUnit.getAttachment(Attachments.DEPLOYMENT_ROOT);
final ModuleSpecification moduleSpecification = deploymentUnit.getAttachment(Attachments.MODULE_SPECIFICATION);
final ModuleLoader moduleLoader = deploymentUnit.getAttachment(Attachments.SERVICE_MODULE_LOADER);
final ModuleIdentifier moduleIdentifier = deploymentUnit.getAttachment(Attachments.MODULE_IDENTIFIER);
final String moduleIdentifier = deploymentUnit.getAttachment(Attachments.MODULE_IDENTIFIER).toString();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could have been changed to MODULE_NAME and avoid using the deprecated version, but #6298 is not merged at this stage so ... OK

@yersan yersan added the ready-for-merge This PR is ready to be merged and fulfills all requirements label Dec 23, 2024
@yersan yersan merged commit 5054f88 into wildfly:main Dec 23, 2024
10 of 13 checks passed
@bstansberry bstansberry deleted the WFCORE-7112 branch January 2, 2025 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yersan yersan yersan approved these changes

Assignees
No one assigned
Labels
ready-for-merge This PR is ready to be merged and fulfills all requirements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bstansberry @wildfly-ci @yersan