WFCORE-6668 Ensure read-feature-description results contain stability as reported by associated description for use by WildFly Glow #5842

pferraro · 2024-01-19T15:40:30Z

https://issues.redhat.com/browse/WFCORE-6668

pferraro · 2024-01-19T15:41:19Z

@jfdenise This should be in better shape now.

jfdenise · 2024-01-19T16:43:45Z

@pferraro , I tried and I don't see what I was expecting.
I have batch-jberet to be a fake Prevew feature:

@Override
public Stability getStability() {
    return Stability.PREVIEW;
}

I am building the feature-pack with preview as minimum, provisioning with preview. Starting the server with --stability=preview, the reported stability level for /subsystem=batch-jberet:read-feature-description is default. I was expecting it to be preview

I am perhaps missing something.

pferraro · 2024-01-19T17:19:48Z

@OverRide
public Stability getStability() {
return Stability.PREVIEW;
}

Which class did you override?

pferraro · 2024-01-19T17:30:50Z

Ah - you must have overridden the Stability of the extension. I'll need to ensure that the resource definition of the extension reflects its stability level so that the corresponding MMR.getStability() returns the expected value.

wildfly-ci · 2024-01-22T06:30:51Z

Core -> Full Integration Build 13429 outcome was FAILURE using a merge of ab5f793
Summary: Execution timeout (new) Build time: 10:00:30

wildfly-ci · 2024-01-22T06:30:52Z

Core -> WildFly Preview Integration Build 13253 outcome was FAILURE using a merge of ab5f793
Summary: Execution timeout (new) Build time: 10:00:32

wildfly-ci · 2024-01-22T06:32:24Z

Core -> Full Integration Build 13190 outcome was FAILURE using a merge of ab5f793
Summary: Execution timeout (new) Build time: 10:01:40

jfdenise · 2024-01-22T14:06:17Z

@pferraro, yes, the extension. In such a case, should all defined resources/attributes located in the extension be at least at the extension stability level? It could apply to any hierarchy, the stability, if not redefined locally, being inherited from the parent.

pferraro · 2024-01-22T15:59:21Z

Latest changes seem to have caused the feature spec generator to hang. I will nvestigate/
A complication with the read-feature-description: The /extension=* resource description will always have DEFAULT stability - since this is a wildcard resource definition.
I can experiment with creating override definitions for extensions with non-default stability, but I'm not sure how well this will reflected in the read-feature-description operation.

@pferraro, yes, the extension. In such a case, should all defined resources/attributes located in the extension be at least at the extension stability level? It could apply to any hierarchy, the stability, if not redefined locally, being inherited from the parent.

That said, with the above changes, the corresponding /subsystem=* resource definitions and their child resources, will all inherit the max stability of the extension that created them.

Unfortunately, for objects associated with resource definitions; e.g. like AttributeDefinitions, OperationDefinitions, Notifications, etc.; cannot get the same treatment, since none of these abstractions are encapsulated by interfaces that can be reasonably decorated.

…inition. MRR.enables(...) should very that target feature is enabled by stability level of the process. Update OperationContext.getStability() so as not to rely on MMR.getStability().

…ibute descriptions.

pferraro · 2024-01-31T17:46:08Z

@jfdenise OK - this should be working now.

pferraro · 2024-01-31T18:28:20Z

I'm sorting through the test failures, but at least we are no longer hanging while generating feature specs...

… as reported by associated description.

…tors.

jfdenise · 2024-02-01T15:10:24Z

@pferraro , thank-you! I can see the stability level at the extension level and the sub resources inheriting it.

yersan · 2024-02-07T09:29:33Z

/retest

jfdenise

Fine with me with respect to Galleon provisioning.

wildfly-ci · 2024-02-07T11:36:00Z

Core -> Full Integration Build 13223 outcome was FAILURE using a merge of 02ae8ee
Summary: Tests failed: 1 (1 new), passed: 3947, ignored: 59 Build time: 02:05:54

Failed tests

org.wildfly.test.integration.microprofile.faulttolerance.micrometer.FaultToleranceMicrometerIntegrationTestCase(layers-test).checkCounters: java.lang.AssertionError: expected:<10.0> but was:<0.0>
	at deployment.FaultToleranceMicrometerIntegrationTestCase.war//org.wildfly.test.integration.microprofile.faulttolerance.micrometer.FaultToleranceMicrometerIntegrationTestCase.checkCounters(FaultToleranceMicrometerIntegrationTestCase.java:94)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at deployment.arquillian-service//org.jboss.as.arquillian.service.ArquillianService$ExtendedJMXTestRunner.doRunTestMethod(ArquillianService.java:204)
	at deployment.arquillian-service//org.jboss.as.arquillian.service.ArquillianService$ExtendedJMXTestRunner.runTestMethod(ArquillianService.java:179)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor12.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
	at java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46)
	at java.management/com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
	at java.management/com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
	at java.management/com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
	at java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:809)
	at java.management/com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)
	at [email protected]//org.jboss.as.jmx.PluggableMBeanServerImpl$TcclMBeanServer.invoke(PluggableMBeanServerImpl.java:1482)
	at [email protected]//org.jboss.as.jmx.PluggableMBeanServerImpl.invoke(PluggableMBeanServerImpl.java:714)
	at [email protected]//org.jboss.as.jmx.BlockingNotificationMBeanServer.invoke(BlockingNotificationMBeanServer.java:151)
	at [email protected]//org.jboss.as.jmx.AuthorizingMBeanServer.invoke(AuthorizingMBeanServer.java:245)
	at [email protected]//org.jboss.remotingjmx.protocol.v2.ServerProxy$InvokeHandler.handle(ServerProxy.java:947)

wildfly-ci · 2024-02-07T17:26:37Z

Core -> Full Integration Build 13224 outcome was FAILURE using a merge of 02ae8ee
Summary: Tests failed: 1, passed: 3947, ignored: 59 Build time: 01:59:02

Failed tests

org.wildfly.test.integration.microprofile.faulttolerance.micrometer.FaultToleranceMicrometerIntegrationTestCase(layers-test).checkCounters: java.lang.AssertionError: expected:<10.0> but was:<0.0>
	at deployment.FaultToleranceMicrometerIntegrationTestCase.war//org.wildfly.test.integration.microprofile.faulttolerance.micrometer.FaultToleranceMicrometerIntegrationTestCase.checkCounters(FaultToleranceMicrometerIntegrationTestCase.java:94)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at deployment.arquillian-service//org.jboss.as.arquillian.service.ArquillianService$ExtendedJMXTestRunner.doRunTestMethod(ArquillianService.java:204)
	at deployment.arquillian-service//org.jboss.as.arquillian.service.ArquillianService$ExtendedJMXTestRunner.runTestMethod(ArquillianService.java:179)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor12.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
	at java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46)
	at java.management/com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
	at java.management/com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
	at java.management/com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
	at java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:809)
	at java.management/com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)
	at [email protected]//org.jboss.as.jmx.PluggableMBeanServerImpl$TcclMBeanServer.invoke(PluggableMBeanServerImpl.java:1482)
	at [email protected]//org.jboss.as.jmx.PluggableMBeanServerImpl.invoke(PluggableMBeanServerImpl.java:714)
	at [email protected]//org.jboss.as.jmx.BlockingNotificationMBeanServer.invoke(BlockingNotificationMBeanServer.java:151)
	at [email protected]//org.jboss.as.jmx.AuthorizingMBeanServer.invoke(AuthorizingMBeanServer.java:245)
	at [email protected]//org.jboss.remotingjmx.protocol.v2.ServerProxy$InvokeHandler.handle(ServerProxy.java:947)

wildfly-ci · 2024-02-07T23:08:09Z

Core -> Full Integration Build 13225 outcome was FAILURE using a merge of 02ae8ee
Summary: Tests failed: 1, passed: 3949, ignored: 59 Build time: 01:50:24

Failed tests

org.wildfly.test.integration.microprofile.faulttolerance.micrometer.FaultToleranceMicrometerIntegrationTestCase(layers-test).checkCounters: java.lang.AssertionError: expected:<10.0> but was:<0.0>
	at deployment.FaultToleranceMicrometerIntegrationTestCase.war//org.wildfly.test.integration.microprofile.faulttolerance.micrometer.FaultToleranceMicrometerIntegrationTestCase.checkCounters(FaultToleranceMicrometerIntegrationTestCase.java:94)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at deployment.arquillian-service//org.jboss.as.arquillian.service.ArquillianService$ExtendedJMXTestRunner.doRunTestMethod(ArquillianService.java:204)
	at deployment.arquillian-service//org.jboss.as.arquillian.service.ArquillianService$ExtendedJMXTestRunner.runTestMethod(ArquillianService.java:179)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at jdk.internal.reflect.GeneratedMethodAccessor12.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:112)
	at java.management/com.sun.jmx.mbeanserver.StandardMBeanIntrospector.invokeM2(StandardMBeanIntrospector.java:46)
	at java.management/com.sun.jmx.mbeanserver.MBeanIntrospector.invokeM(MBeanIntrospector.java:237)
	at java.management/com.sun.jmx.mbeanserver.PerInterface.invoke(PerInterface.java:138)
	at java.management/com.sun.jmx.mbeanserver.MBeanSupport.invoke(MBeanSupport.java:252)
	at java.management/com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:809)
	at java.management/com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:801)
	at [email protected]//org.jboss.as.jmx.PluggableMBeanServerImpl$TcclMBeanServer.invoke(PluggableMBeanServerImpl.java:1482)
	at [email protected]//org.jboss.as.jmx.PluggableMBeanServerImpl.invoke(PluggableMBeanServerImpl.java:714)
	at [email protected]//org.jboss.as.jmx.BlockingNotificationMBeanServer.invoke(BlockingNotificationMBeanServer.java:151)
	at [email protected]//org.jboss.as.jmx.AuthorizingMBeanServer.invoke(AuthorizingMBeanServer.java:245)
	at [email protected]//org.jboss.remotingjmx.protocol.v2.ServerProxy$InvokeHandler.handle(ServerProxy.java:947)

yersan · 2024-02-12T14:04:47Z

@pferraro / @jfdenise Are we fine treating this as a task and not as a feature request? This is going to add a new field exposing additional information and its requirement is driven by a feature request, so I ran into the doubt when I was going to merge it.

Adding a hold label until it gets confirmed.

jfdenise · 2024-02-12T15:04:26Z

@yersan , I would say yes, this operation is not exposed, it is there to be consumed by Galleon.

yersan · 2024-02-13T11:06:04Z

Thanks @pferraro @jfdenise @bstansberry

pferraro requested a review from jfdenise January 19, 2024 15:40

github-actions bot added the deps-ok Dependencies have been checked, and there are no significant changes label Jan 19, 2024

This comment was marked as outdated.

Sign in to view

pferraro force-pushed the WFCORE-6668 branch from d3d4439 to ab5f793 Compare January 21, 2024 20:26

pferraro added 3 commits January 31, 2024 12:00

Let Capability extend Feature, rather than RuntimeCapability.

b1cf9ce

MRR.getStability() should return stability of registered resource def…

4e8cf15

…inition. MRR.enables(...) should very that target feature is enabled by stability level of the process. Update OperationContext.getStability() so as not to rely on MMR.getStability().

WFCORE-6668 Expose stability via resource/operation/notification/attr…

255cbdd

…ibute descriptions.

pferraro force-pushed the WFCORE-6668 branch from ab5f793 to 298cda4 Compare January 31, 2024 17:45

This comment was marked as outdated.

Sign in to view

pferraro added 2 commits January 31, 2024 17:08

WFCORE-6668 Ensure read-feature-description results contain stability…

de988e2

… as reported by associated description.

Generalize DelegatingResourceDefinition to accomodate non-lazy decora…

bcb4489

…tors.

pferraro force-pushed the WFCORE-6668 branch from 298cda4 to b4f5f80 Compare January 31, 2024 22:08

This comment was marked as outdated.

Sign in to view

pferraro added 2 commits January 31, 2024 20:13

Auto-propagate stability level to child resources, if necessary.

1592ee4

Auto-propagate extension stability to subsystem model, if necessary.

15ea126

Override parameter name in parameterized test.

02ae8ee

pferraro force-pushed the WFCORE-6668 branch from b4f5f80 to 02ae8ee Compare February 1, 2024 01:13

This comment was marked as outdated.

Sign in to view

pferraro mentioned this pull request Feb 2, 2024

WFCORE-6668 Ensure read-feature-description results contain stability as reported by associated description for use by WildFly Glow wildfly/wildfly#17589

Merged

jfdenise approved these changes Feb 7, 2024

View reviewed changes

yersan requested a review from ehsavoie February 8, 2024 09:21

yersan approved these changes Feb 9, 2024

View reviewed changes

yersan added ready-for-merge This PR is ready to be merged and fulfills all requirements hold Do not merge this PR labels Feb 9, 2024

yersan removed the hold Do not merge this PR label Feb 13, 2024

yersan merged commit a5fa757 into wildfly:main Feb 13, 2024
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WFCORE-6668 Ensure read-feature-description results contain stability as reported by associated description for use by WildFly Glow #5842

WFCORE-6668 Ensure read-feature-description results contain stability as reported by associated description for use by WildFly Glow #5842

pferraro commented Jan 19, 2024

pferraro commented Jan 19, 2024

jfdenise commented Jan 19, 2024

pferraro commented Jan 19, 2024

pferraro commented Jan 19, 2024

This comment was marked as outdated.

This comment was marked as outdated.

wildfly-ci commented Jan 22, 2024

wildfly-ci commented Jan 22, 2024

wildfly-ci commented Jan 22, 2024

jfdenise commented Jan 22, 2024

pferraro commented Jan 22, 2024

pferraro commented Jan 31, 2024

pferraro commented Jan 31, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

jfdenise commented Feb 1, 2024

yersan commented Feb 7, 2024

jfdenise left a comment

wildfly-ci commented Feb 7, 2024

wildfly-ci commented Feb 7, 2024

wildfly-ci commented Feb 7, 2024

yersan commented Feb 12, 2024

jfdenise commented Feb 12, 2024

yersan commented Feb 13, 2024

WFCORE-6668 Ensure read-feature-description results contain stability as reported by associated description for use by WildFly Glow #5842

WFCORE-6668 Ensure read-feature-description results contain stability as reported by associated description for use by WildFly Glow #5842

Conversation

pferraro commented Jan 19, 2024

pferraro commented Jan 19, 2024

jfdenise commented Jan 19, 2024

pferraro commented Jan 19, 2024

pferraro commented Jan 19, 2024

This comment was marked as outdated.

This comment was marked as outdated.

wildfly-ci commented Jan 22, 2024

wildfly-ci commented Jan 22, 2024

wildfly-ci commented Jan 22, 2024

jfdenise commented Jan 22, 2024

pferraro commented Jan 22, 2024

pferraro commented Jan 31, 2024

pferraro commented Jan 31, 2024

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

jfdenise commented Feb 1, 2024

yersan commented Feb 7, 2024

jfdenise left a comment

Choose a reason for hiding this comment

wildfly-ci commented Feb 7, 2024

Failed tests

wildfly-ci commented Feb 7, 2024

Failed tests

wildfly-ci commented Feb 7, 2024

Failed tests

yersan commented Feb 12, 2024

jfdenise commented Feb 12, 2024

yersan commented Feb 13, 2024