[WFCORE-5917] Use variable expansion replacement instead of pattern r…

[yersan]

…emoving to avoid duplicate jboss.server.base.dir options

Jira issue: https://issues.redhat.com/browse/WFCORE-5917

[jamezp]

I'm not sure this is correct. This will remove the -Djboss.server.base.dir from the SERVER_OPTS. While the original way this was done doesn't seem correct either, I don't think this is.

Really having it defined twice isn't a huge issue. However, we need to be able to override it from the command line.

[yersan]

@jamezp

This will remove the -Djboss.server.base.dir from the SERVER_OPTS.

This variable is not exported so is not visible to the server process. After removing the option, which is duplicated later in the server command launch (see that it explicitly uses -Djboss.server.base.dir=\""$JBOSS_BASE_DIR"\" \, the server needs to be stopped and started again to use it, which will initialize it back to the original value. I mean, it is unused after removing the duplicated option on this line.

The domain.sh has the same issue.

Really having it defined twice isn't a huge issue.

Yes, I agree, it is just the point of having it twice for the same server launch command line.

However, we need to be able to override it from the command line.

This change does not affect this calculation. This is done when the options are consolidated above this change, L140.

[wildfly-ci]

Core -> WildFly Preview Integration Build 13244 outcome was FAILURE using a merge of 143dfa3
Summary: Execution timeout (new); tests passed: 2024, ignored: 18 Build time: 10:00:32

[lvydra]

Thanks @yersan, now it's working as it was formerly intended. @jamezp At the point of removing -Djboss.server.base.dir from the SERVER_OPTS, that one should be already processed as part of opts consolidation.

[jamezp]

Sorry, I must have been looking at something wrong in my testing. This does seem work, my apologies.

[yersan]

converting to draft, since although the approach is approved, we found we need to apply the same to domain.sh and potentially, look at batch ps1 scripts too, and or check if we can add a validation test to it.

[wildfly-ci]

Core -> WildFly Preview Integration Build 13263 outcome was UNKNOWN using a merge of 7c5135d
Summary: Canceled (Exit code 143 (Step: Build & test full (Maven))) Build time: 00:07:03

[wildfly-ci]

Core -> Full Integration Build 13200 outcome was UNKNOWN using a merge of 7c5135d
Summary: Canceled (Exit code 143 (Step: Build & test full (Maven)) (new)) Build time: 00:07:03

[wildfly-ci]

Core -> Full Integration Build 13439 outcome was UNKNOWN using a merge of 7c5135d
Summary: Canceled (Tests passed: 1281, ignored: 6; exit code 143 (Step: Build & test full (Maven)) (new)) Build time: 00:07:09

[github-actions]

There has been no activity on this PR for 45 days. It will be auto-closed after 90 days.

[github-actions]

There has been no activity on this PR for 90 days and it has been closed automatically.