Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GAL-368 Fix FormattingXmlStreamWriter.writeStartElement(...) delegation #355

Closed
wants to merge 2 commits into from
Closed

GAL-368 Fix FormattingXmlStreamWriter.writeStartElement(...) delegation #355

wants to merge 2 commits into from

Conversation

pferraro
Copy link
Contributor

@pferraro
GAL-368 Fix FormattingXmlStreamWriter.writeStartElement(...) delegation
ae820dc 
Also FormattingXmlStreamWriter.writeEmptyElement(...)
@pferraro
GAL-368 Fix FormattingXmlStreamWriter.writeStartElement(...) delegation
3be9098 
Also FormattingXmlStreamWriter.writeEmptyElement(...)
@jfdenise
Copy link
Contributor

@pferraro , would you mind update the copyright year of the updated files? This is what breaks the CI. Thank-you.

@pferraro
Copy link
Contributor Author

@jfdenise I'm confused. Why would a bug fix require updating a copyright header?

@jfdenise
Copy link
Contributor

@pferraro , galleon has some rules to update the copyright on file changes.

@jfdenise
Copy link
Contributor

@pferraro , I created #357 that contains your changes and copyright update.

@jfdenise jfdenise closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfdenise jfdenise Awaiting requested review from jfdenise jfdenise is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pferraro @jfdenise