Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting manifest coordinates via system property #395

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

TomasHofman
Copy link
Contributor

This ports the ability to configure manifest locations via the wildfly.channels system property from the wildfly-maven-plugin (wildfly/wildfly-maven-plugin#417).

It was requested to have this in the jar plugin as well (Cc @mnovak1).

@TomasHofman
Copy link
Contributor Author

@jfdenise I can see DevWatchTestCase.testDevWatchWeb failing in multiple jobs, but I can see that test failing on older PRs too. I guess that is a know issue?

@jfdenise
Copy link
Collaborator

@TomasHofman , yes that is a remaining failing random test that we had hard time to fix. That is expected.

@jfdenise jfdenise merged commit aa352b8 into wildfly-extras:main Apr 30, 2024
7 of 12 checks passed
@jfdenise
Copy link
Collaborator

@TomasHofman , thank-you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants