channel list output is confusing #755 #777
Open
+57
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spyrkob
requested changes
Oct 16, 2024
| if (fullList) { | ||
| console.println(ChannelMapper.toYaml(channels)); | ||
| } else { | ||
| console.println(channel.getName() + " " + channel.getManifestCoordinate().getGroupId() + ":" + channel.getManifestCoordinate().getArtifactId() + ":" + |
There was a problem hiding this comment.
This needs to handle following cases:
- Manifest coordinate is a Maven coordinate with full GAV
- Manifest coordinate is a Maven coordinate with just GA
- Manifest coordinate is an URL
- There is no manifest coordinate at all (we should print the value no-stream-strategy and ids of the repositories in this case)
| @@ -53,6 +53,9 @@ public static class ChannelListCommand extends AbstractCommand { | |||
| @CommandLine.Option(names = CliConstants.DIR) | |||
| Optional<Path> directory; | |||
|
|
|||
| @CommandLine.Option(names = CliConstants.FULL) | |||
There was a problem hiding this comment.
New options need to be described in the UsageMessages.properties
| @@ -191,7 +191,33 @@ public void testList() { | |||
| int exitCode = commandLine.execute(CliConstants.Commands.CHANNEL, CliConstants.Commands.LIST, | |||
| CliConstants.DIR, dir.toString()); | |||
| Assert.assertEquals(ReturnCodes.SUCCESS, exitCode); | |||
| Assert.assertEquals(3, getStandardOutput().lines().filter(l->l.contains("manifest")).count()); | |||
| Assert.assertEquals(3, getStandardOutput().lines() | |||
There was a problem hiding this comment.
Use Assertions.assertThat and compare it to actual expected lines ("test1 g:a", "test2 g:a:v", "test3 file:/a:b")
| CliConstants.DIR, dir.toString()); | ||
| Assert.assertEquals(ReturnCodes.SUCCESS, exitCode); | ||
| String output = getStandardOutput(); | ||
| Assert.assertTrue("Expected 'schemaVersion' in the output", |
There was a problem hiding this comment.
The test doesn't actually verify that the correct values are printed. You should be able to get the output, convert it back to Channel objects and compare with the input.
Or simply compare the output with serialized input.
|
@spyrkob, I have updated the code according to the review comments. Please have a look and let me know if more changes are needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #755