Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YiR] Share slide #5034

Merged
merged 12 commits into from
Oct 28, 2024
Merged

[YiR] Share slide #5034

merged 12 commits into from
Oct 28, 2024

Conversation

mazevedofs
Copy link
Collaborator

@mazevedofs mazevedofs commented Oct 25, 2024

Phabricator: https://phabricator.wikimedia.org/T376300

Notes

  • This PR adds the ability to share a slide using a system UIActivityViewController
  • For that, I'm creating a separate View derived from the slide, creating a snapshot and saving it as a UIImage
  • After discussing with Design, we do not have a "preview" step and we're always setting the shared image size to an iPhone-sized image, even when sharing from iPad
  • I'm adding the bottom card with the hashtag, even though it was nice to have on the phab ticket

Test Steps

  1. Set device to either Italy, Mexico
  2. Set primary app language to a supported lang - en, it, es
  3. Tap through 5+ articles
  4. Go to the developer settings menu, enable the feature flag
  5. Background/foreground the app to populate the report
  6. Tap profile, you should see the entry point
  7. On a slide, click share. Share to a message, slack, etc
  8. Verify UI and text
  9. Test from iPad
  10. Test flow coming from the announcement if possible, to check for coordinator issues

@mazevedofs mazevedofs requested review from a team and l-olson1214 and removed request for a team October 25, 2024 19:19
@l-olson1214 l-olson1214 merged commit 65a4e5b into main Oct 28, 2024
4 checks passed
@l-olson1214 l-olson1214 deleted the share-yir branch October 28, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants