Table Views: Move to inset groups. #4951
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelynharthbrooke
force-pushed
the
inset-groups
branch
2 times, most recently
from
fb87833
to
e2dbafb
Compare
|
Hi @evelynharthbrooke, thank you for the improvement! I have created an associated Phabricator task so that our designer can take a look - https://phabricator.wikimedia.org/T374283. I am putting these changes through design review before we merge and will update this PR if any tweaks are needed. |
evelynharthbrooke
force-pushed
the
inset-groups
branch
3 times, most recently
from
e2fee52
to
83e1fb2
Compare
|
@tonisevener any changes necessary for this to be merged? i saw the phabricator task and it seems like there's nothing blocking this from being merged from what i can tell but if you need anything from me let me know! |
evelynharthbrooke
force-pushed
the
inset-groups
branch
2 times, most recently
from
ec39720
to
56bbb05
Compare
evelynharthbrooke
force-pushed
the
inset-groups
branch
from
56bbb05
to
2b04f87
Compare
This change switches settings, libraries used, and the watchlist filtering view to use the new inset grouped style that was introduced with iOS 14 and above. It also migrates notification filtering and inbox views to use inset groups as well. This is a step towards modernizing the app to conform to modern iOS style guidelines.
evelynharthbrooke
force-pushed
the
inset-groups
branch
from
2b04f87
to
b0d3dba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: N/A
Notes
Test Steps
Screenshots/Videos