Refactor ReadingListFragment to use ViewModel. #5214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terofeev
commented
Jan 9, 2025
| } | ||
| } | ||
|
|
||
| class ReadingListWrapper(val readingList: ReadingList?) |
There was a problem hiding this comment.
Added wrapper class because the data has non-nullable type T.
open class Resource<T> {
...
class Success<T>(val data: T) : Resource<T>()
...
}
There was a problem hiding this comment.
Instead of having a wrapper class, can we send an empty list if the list is null? or can you please handle the null list by sending an error?
# Conflicts: # app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.kt
cooltey
requested changes
Feb 15, 2025
| fun getEmptyTitle(context: Context) = context.getString(R.string.reading_lists_preview_header_title) | ||
|
|
||
| fun getEmptyDescription(context: Context) = DateUtil.getTimeAndDateString(context, Date()) | ||
|
|
||
| suspend fun receiveReadingLists(context: Context, json: String, encoded: Boolean): ReadingList { |
There was a problem hiding this comment.
The following changes make this function unused, would it be possible to avoid/undo the change below?
| } | ||
| } | ||
|
|
||
| class ReadingListWrapper(val readingList: ReadingList?) |
There was a problem hiding this comment.
Instead of having a wrapper class, can we send an empty list if the list is null? or can you please handle the null list by sending an error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
ReadingListFragmentto use ViewModel.ReadingListFragmentViewModeland moved the update list logic into it.Why is this needed?
Tech-debt.
Reduce complexity by simplifying the UI layer.
Phabricator:
https://phabricator.wikimedia.org/T303935