[Contributions dashboard] app icon #5055
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update manifest file to include activity alias for default icon - shows snackbar when app icon changes
- adds TODO's
…ions-dashboard-design
Williamrai
changed the base branch from
main
to
contributions-dashboard-design
- adds recyclerView for showing different app icon - removes unused code - adds styles for circular image view - adds logic to select/de-select app icon
…nd and optimized code - adds prefs for saving current selected app icon
Williamrai
added
WIP
|
Needs further discussion on this feature, how this would behave on different devices and API level? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Adds the ability for user to update their app icon.
Phabricator:
https://phabricator.wikimedia.org/T376423