[Contributions dashboard] survey dialog #5044

Williamrai · 2024-10-17T19:39:35Z

What does this do?

Adds a function to show material alert dialog with delay functionality.

Why is this needed?

This is needed after a user Saves an update to the Donor History page.

Phabricator:
https://phabricator.wikimedia.org/T376436

…into contributions-dashboard-design-survey-dialog

… extension for AppCompatActivity

…board-design-survey-dialog

cooltey · 2024-10-23T18:19:31Z

app/src/main/java/org/wikipedia/views/SurveyDialog.kt

+                .setTitle(titleId)
+                .setMessage(messageId)
+                .setCancelable(isCancellable)
+                .setPositiveButton("Take Survey") { _, _ ->


You can use this R.string.contributions_dashboard_survey_dialog_ok

cooltey · 2024-10-23T18:20:19Z

app/src/main/java/org/wikipedia/views/SurveyDialog.kt

+                        Uri.parse(activity.getString(R.string.contribution_dashboard_survey_url))
+                    )
+                }
+                .setNegativeButton("No, Thanks") { _, _ ->


You can use this R.string.contributions_dashboard_entry_dialog_cancel

this should use R.string.contributions_dashboard_survey_dialog_cancel. Figma

cooltey · 2024-10-23T20:08:54Z

app/src/main/java/org/wikipedia/views/SurveyDialog.kt

+        activity: AppCompatActivity,
+        @StringRes titleId: Int,
+        @StringRes messageId: Int,
+        @DrawableRes icon: Int? = null,


I think we will only need one survey verbiage for this experiment, maybe we can either set the title and message directly in the dialog, or set default values for title, message and icon?

removed from here and moved to SuggestedEditsTasksFragment

cooltey · 2024-10-23T20:09:41Z

app/src/main/java/org/wikipedia/views/SurveyDialog.kt

+                    )
+                }
+                .setNegativeButton("No, Thanks") { _, _ ->
+                    // dismiss


We will need a preference for this dialog, since we are going to show this once after saving the donor history.

cooltey · 2024-10-23T20:13:23Z

app/src/main/res/drawable/ic_feedback.xml

@@ -0,0 +1,9 @@
+<vector xmlns:android="http://schemas.android.com/apk/res/android"


Not sure but did you use the icon from the Figma design or the material design library? If it was from the Figma design, I think we can import the icon from the material design library directly in case Sarah wants the exact design from her design.

The icon Sarah used was in the material design library, so i imported from there.

cooltey · 2024-10-23T20:18:58Z

app/src/main/java/org/wikipedia/views/SurveyDialog.kt

+        delayMillis: Long = 0,
+        isCancellable: Boolean = false
+    ) {
+        activity.lifecycleScope.launch {


May I know why we are using the Coroutine here?

cooltey · 2024-10-23T20:19:13Z

app/src/main/java/org/wikipedia/views/SurveyDialog.kt

+            withContext(Dispatchers.Main) {
+                dialog.show()
+            }


…dEditsTasksFragment

cooltey · 2024-10-25T21:53:55Z

app/src/main/java/org/wikipedia/settings/Prefs.kt

@@ -750,4 +750,8 @@ object Prefs {
    var isRecurringDonor
        get() = PrefsIoUtil.getBoolean(R.string.preference_key_is_recurring_donor, false)
        set(value) = PrefsIoUtil.setBoolean(R.string.preference_key_is_recurring_donor, value)
+
+    var contributionDashboardSurveyDialogShown


Please rename contribution to plural.

cooltey · 2024-10-25T21:55:18Z

app/src/main/res/values/strings_no_translate.xml

@@ -22,6 +22,7 @@
    <string name="donate_tax_url">https://donate.wikimedia.org/wiki/Special:LandingCheck?landing_page=Tax_deductibility&amp;basic=true</string>
    <string name="donate_email">[email protected]</string>
    <string name="donor_privacy_policy_url">https://foundation.wikimedia.org/wiki/Policy:Donor_privacy_policy</string>
+    <string name="contribution_dashboard_survey_url">https://docs.google.com/forms/d/1wIJWp75MMyp2e51kSaPH9ctByUzbyhazEOaJTxQhKqs/edit</string>


Same: contribution -> contributions

cooltey · 2024-10-25T21:56:21Z

app/src/main/java/org/wikipedia/views/SurveyDialog.kt

If there are no changes in this file, would it be possible to reset the change and make another PR for the format updates?

cooltey · 2024-10-25T22:08:24Z

app/src/main/java/org/wikipedia/suggestededits/SuggestedEditsTasksFragment.kt

@@ -388,6 +393,32 @@ class SuggestedEditsTasksFragment : Fragment() {
        }
    }

+    private fun showSurveyDialog(


Since this dialog will not be reused in other places, can we make this even simpler, just like this?

Please make sure to add a check for the preference for the one-time popup purpose.

apps-android-wikipedia/app/src/main/java/org/wikipedia/main/MainFragment.kt

Lines 547 to 557 in 89412c1

private fun maybeShowImportReadingListsNewInstallDialog() {

if (!Prefs.importReadingListsNewInstallDialogShown) {

ReadingListsAnalyticsHelper.logReceiveStart(requireActivity())

MaterialAlertDialogBuilder(requireContext())

.setTitle(R.string.shareable_reading_lists_new_install_dialog_title)

.setMessage(R.string.shareable_reading_lists_new_install_dialog_content)

.setNegativeButton(R.string.shareable_reading_lists_new_install_dialog_got_it, null)

.show()

Prefs.importReadingListsNewInstallDialogShown = true

}

}

Williamrai added 7 commits October 15, 2024 16:18

Merge branch 'main' into contributions-dashboard-design

05771ac

- adds a survey dialog

ee925f0

Merge remote-tracking branch 'origin/contributions-dashboard-design' …

1569fe7

…into contributions-dashboard-design-survey-dialog

- adds a general simple alert dialog

266d513

- converts the SimpleAlertDialog function to a class with easy to use…

26ff91d

… extension for AppCompatActivity

- adds contribution survey dialog to SurveyDialog object

c52a05f

- adds survey link cta on alert dialog positive button

58e64d4

Williamrai requested review from cooltey and dbrant as code owners October 17, 2024 19:39

Williamrai changed the base branch from main to contributions-dashboard-design October 17, 2024 19:40

Merge branch 'contributions-dashboard-design' into contributions-dash…

dae3fcb

…board-design-survey-dialog

cooltey requested changes Oct 23, 2024

View reviewed changes

Williamrai added 3 commits October 24, 2024 14:20

- removes dialog from SurveyDialog object and adds it to the Suggeste…

dc398f1

…dEditsTasksFragment

- adds contributionDashboardSurveyDialogShown preference

c00a14e

- small code fix

b2b39c4

Williamrai requested a review from cooltey October 25, 2024 19:01

cooltey requested changes Oct 25, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Contributions dashboard] survey dialog #5044

[Contributions dashboard] survey dialog #5044

Williamrai commented Oct 17, 2024

cooltey Oct 23, 2024

Williamrai Oct 24, 2024

cooltey Oct 23, 2024

Williamrai Oct 24, 2024

cooltey Oct 23, 2024

Williamrai Oct 24, 2024

cooltey Oct 23, 2024

Williamrai Oct 24, 2024

cooltey Oct 23, 2024

Williamrai Oct 24, 2024

cooltey Oct 23, 2024

Williamrai Oct 24, 2024

cooltey Oct 23, 2024

Williamrai Oct 24, 2024

cooltey Oct 25, 2024

cooltey Oct 25, 2024

cooltey Oct 25, 2024

cooltey Oct 25, 2024

		@@ -0,0 +1,9 @@
		<vector xmlns:android="http://schemas.android.com/apk/res/android"

	private fun maybeShowImportReadingListsNewInstallDialog() {
	if (!Prefs.importReadingListsNewInstallDialogShown) {
	ReadingListsAnalyticsHelper.logReceiveStart(requireActivity())
	MaterialAlertDialogBuilder(requireContext())
	.setTitle(R.string.shareable_reading_lists_new_install_dialog_title)
	.setMessage(R.string.shareable_reading_lists_new_install_dialog_content)
	.setNegativeButton(R.string.shareable_reading_lists_new_install_dialog_got_it, null)
	.show()
	Prefs.importReadingListsNewInstallDialogShown = true
	}
	}

[Contributions dashboard] survey dialog #5044

Are you sure you want to change the base?

[Contributions dashboard] survey dialog #5044

Conversation

Williamrai commented Oct 17, 2024

What does this do?

Why is this needed?

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment