fix: allow usage of use_reactive from outside kernel_context #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
fix_use_reactive_kernel_scoped
branch
from
c402b1f to
54cb968
Compare
If the reactive variable return from use_reactive is set from outside a kernel_context, the reactive variable would not be set. This bug is demonstrated in: https://py.cafe/maartenbreddels/solara-shared-state Where we had to force use_trait_observe to use use_state in of use_reactive.
maartenbreddels
force-pushed
the
fix_use_reactive_kernel_scoped
branch
from
54cb968 to
8e579e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the reactive variable return from use_reactive is set from outside a kernel_context, the reactive variable would not be set.
This bug is demonstrated in:
https://py.cafe/maartenbreddels/solara-shared-state
Where we had to force use_trait_observe to use use_state in of use_reactive.