docs update code hbox #890
Open
+4
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iisakkirotko
approved these changes
Dec 6, 2024
iisakkirotko
force-pushed
the
docs_update_code_hbox
branch
from
e593877 to
d7807ba
Compare
iisakkirotko
requested changes
Dec 6, 2024
There was a problem hiding this comment.
Here we need to keep Hbox, since that's what the page is showcasing.
I see there is already a deprecation notice in the component definition at
solara/solara/components/misc.py
Line 149 in a980aa5
Could you also add a deprecation notice to this page @lizzy985?
| ColorCard(color, color) | ||
| return main | ||
| colors = "green red orange brown yellow pink".split() | ||
| with solara.Row(): |
There was a problem hiding this comment.
Suggested change
| with solara.Row(): | |
| with solara.HBox(): |
maartenbreddels
force-pushed
the
master
branch
2 times, most recently
from
cded5b2 to
32af76f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.