-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(weekly topup): create on the account creation form #96
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
81d5c58
feat(weekly topup): create on the account creation form
andreybakanovsky d88ebda
feat(weekly topup): update tests
andreybakanovsky e76c630
feat(weekly topup): fix tests
andreybakanovsky a6d2ed9
Revert "feat(weekly topup): update tests"
andreybakanovsky d1177e0
feat(weekly topup): fix
andreybakanovsky 7198fa7
feat(weekly topup): fix style
andreybakanovsky 52417aa
feat(weekly topup): update the solution
andreybakanovsky File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
class AccountAutomaticTopupConfig < ApplicationRecord | ||
belongs_to :from_account, class_name: 'Account', foreign_key: :from_account_id | ||
belongs_to :to_account, class_name: 'Account', foreign_key: :to_account_id | ||
belongs_to :to_account, class_name: 'Account', foreign_key: :to_account_id, optional: true | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,15 @@ | ||
.columns.is-centered | ||
.column.is-one-third | ||
h2.title.is-4.has-text-centered New account | ||
= form_with url: accounts_path do |f| | ||
= form_with model: @account do |f| | ||
.field | ||
= f.text_field :name, autofocus: true, class: "input", placeholder: "Name" | ||
br | ||
br | ||
div.buttons.is-flex.is-justify-content-flex-end | ||
.field | ||
= f.fields_for :automatic_topup_configs do |auto_topup_form| | ||
= auto_topup_form.text_field :amount, class: "input", placeholder: "Weekly amount (optional)" | ||
= auto_topup_form.hidden_field :from_account_id | ||
.notification.is-light | ||
| This amount will be automatically added to the account every week. You will receive an email notification about that | ||
.buttons.is-flex.is-justify-content-flex-end | ||
= link_to 'Back', my_account_path, class: 'button is-light' | ||
= f.submit 'Save', class: "button is-primary is-fullwidth" | ||
= f.submit 'Save', class: "button is-primary is-fullwidth" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why it's optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was an attempt to resolve the validation issue.