feat(landing page): update style #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ka8725
reviewed
Sep 7, 2023
app/views/accounts/new.html.slim
Outdated
| @@ -8,4 +8,4 @@ | |||
| br | |||
| div.buttons.is-flex.is-justify-content-flex-end | |||
| = link_to 'Back', my_account_path, class: 'button is-light' | |||
| = f.submit 'Save', class: "button is-primary is-fullwidth" | |||
There was a problem hiding this comment.
could we just rewrite the "is-primary" css rule?
There was a problem hiding this comment.
It's not my approach), it's possible
ka8725
reviewed
Sep 7, 2023
app/views/home/index.html.erb
Outdated
| @@ -1,30 +1,28 @@ | |||
| <section class="hero is-white is-halfheight"> | |||
| <section class="hero is-small is-white is-halfheight"> | |||
| <div class="hero-body"> | |||
| <div class="container"> | |||
| <div class="columns is-vcentered reverse-columns"> | |||
There was a problem hiding this comment.
remember in mobile text comes first
There was a problem hiding this comment.
ok, reverse-columns was redefined to stacked-elements
ka8725
reviewed
Sep 7, 2023
app/views/home/index.html.erb
Outdated
| <h1 class="title titled is-1 mb-6"> | ||
| Children wallet | ||
| is-5-fullhd ml-6-pmoney-fullhd"> | ||
| <h1 class="title titled is-1 mb-6 has-text-pmoney-color is-size-3-mobile"> |
There was a problem hiding this comment.
Can we change the css variable so that main text is not black like now but the new one?
VladislavSokov
approved these changes
Sep 8, 2023
andreybakanovsky
commented
Sep 8, 2023
| @import "font-awesome"; | ||
| $text: hsl(270, 50%, 29%); | ||
| $text-light: hsl(270, 50%, 48%); | ||
| $text-strong: hsl(270, 50%, 21%); |
There was a problem hiding this comment.
@ka8725, to get the color as in the picture we need to add $title-color: hsl(270, 50%, 40%); here
Let's look at an option:
- create the unique style for such title font only for the landing page. On other pages use
$title-color = $text-strong: hsl(270, 50%, 21%);
ka8725
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.