fix(public account share): fix public account share buttons and labels #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ka8725
reviewed
Sep 7, 2023
| class AccountsController < ApplicationController | ||
| before_action :authenticate_user! |
There was a problem hiding this comment.
The public shared account should be available for all people (including not logged in). That's why they are public.
ka8725
reviewed
Sep 7, 2023
| @@ -1,8 +1,6 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| class AccountsController < ApplicationController | |||
| before_action :authenticate_user! | |||
There was a problem hiding this comment.
I didn't mean to remove it. Probably that was correct. I just wanted to express that a public account should be available for anonymous. That can be implemented via another controller, for example.
There was a problem hiding this comment.
Yes, that's what I do now
added 2 commits
September 7, 2023 17:26
…are buttons and labels
ka8725
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.