Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(account invitations): rename account invitation to account share #42

Merged
merged 3 commits into from
Aug 30, 2023

Conversation

VladislavSokov
Copy link
Contributor

No description provided.

@@ -12,6 +12,6 @@ def show; end
end

helper_method memoize def shared_accounts
Account.invitees(current_user)
Account.access_recipients(current_user)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Account.access_recipients(current_user)
Account.shared_for(current_user)

@ka8725
Copy link
Member

ka8725 commented Aug 30, 2023

@VladislavSokov it looks good, I just suggest rename the scope to Account.shared_for. Thanks!

@VladislavSokov VladislavSokov marked this pull request as ready for review August 30, 2023 16:42
@ka8725 ka8725 merged commit 15c1beb into master Aug 30, 2023
2 checks passed
@ka8725 ka8725 deleted the rename-invitations branch August 30, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants