feat(account invitation): implement sign in before accepting the invitation #27
Conversation
|
|
||
| def update | ||
| received_invitation.update!(accepted_at: Time.current) | ||
| redirect_to account_path(received_invitation.account_id) |
There was a problem hiding this comment.
I agree that it still was not working, but it was the correct line. Revert it back? Why removed?
There was a problem hiding this comment.
Ok, let's keep
|
|
||
| def show; end | ||
| session[:token] = ps[:token] |
There was a problem hiding this comment.
Better remember after_sign_in_url in the session, this way the after-sign-in redirect implementation will be easy without knowing the internals of possible workflows current or future.
There was a problem hiding this comment.
Global. Beautiful.
| end | ||
|
|
||
| private | ||
|
|
||
| helper_method memoize def received_invitation | ||
| AccountInvitation.unaccepted.for(current_user).find_by!(token: ps.fetch(:token)) | ||
| end | ||
|
|
||
| memoize def the_invitation |
There was a problem hiding this comment.
Remove this check, if they sign in and the after-sign-in link is wrong, they will see 404 page and this is fine. In other words, the code already handles this scenario and no need to write special code for that.
| end | ||
| end | ||
|
|
||
| protected |
There was a problem hiding this comment.
| protected | |
| private |
Learn about protected in Ruby. It's not the same as in the common OOP (like Java).
There was a problem hiding this comment.
I'm aware about. It's just missprint
| if (after_sign_in_url = session.delete(:after_sign_in_url)).present? | ||
| return after_sign_in_url | ||
| end |
There was a problem hiding this comment.
| if (after_sign_in_url = session.delete(:after_sign_in_url)).present? | |
| return after_sign_in_url | |
| end | |
| after_sign_in_url = session.delete(:after_sign_in_url) | |
| return after_sign_in_url if after_sign_in_url.present? |
(don't assign inside boolean expressions, these side-effects are tricky to read and debug)
No description provided.