feat(notification): fix linter warnings

widefix · Sep 11, 2023 · de7d6e4 · de7d6e4
1 parent c22632a
commit de7d6e4
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 14 deletions.
diff --git a/app/controllers/spends_controller.rb b/app/controllers/spends_controller.rb
@@ -11,14 +11,17 @@ def create
       originator: current_user,
       access_token: Devise.friendly_token
     )
-
-    if account.notification?
-      TransactionsMailer.transaction_notification(account).deliver
-      account.account_shares.accepted.each do |account_share|
-        TransactionsMailer.transaction_notification(account, account_share).deliver
-      end
-    end
+    send_notification
 
     redirect_to account_path(account)
   end
+
+  def send_notification
+    return unless account.notification?
+
+    TransactionsMailer.transaction_notification(account).deliver
+    account.account_shares.accepted.each do |account_share|
+      TransactionsMailer.transaction_notification(account, account_share).deliver
+    end
+  end
 end
diff --git a/app/controllers/topups_controller.rb b/app/controllers/topups_controller.rb
@@ -11,14 +11,17 @@ def create
       originator: current_user,
       access_token: Devise.friendly_token
     )
-
-    if account.notification?
-      TransactionsMailer.transaction_notification(account).deliver
-      account.account_shares.accepted.each do |account_share|
-        TransactionsMailer.transaction_notification(account, account_share).deliver
-      end
-    end
+    send_notification
 
     redirect_to account_path(account)
   end
+
+  def send_notification
+    return unless account.notification?
+
+    TransactionsMailer.transaction_notification(account).deliver
+    account.account_shares.accepted.each do |account_share|
+      TransactionsMailer.transaction_notification(account, account_share).deliver
+    end
+  end
 end