Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add similarity measures for time-series data #80

Merged
merged 36 commits into from
Apr 1, 2024
Merged

Add similarity measures for time-series data #80

merged 36 commits into from
Apr 1, 2024

Conversation

Martin-Hoppe
Copy link
Contributor

add dtaidistance, minineedle dependency
add similarit function: regex, glob_regex, n-grams, smith-watmerman, dynamic time warping

add similarit function: regex, glob_regex, n-grams, smith-watmerman, dynamic time warping
@Martin-Hoppe
Copy link
Contributor Author

Es gibt noch einige andere Similarities beim DTW (auch innerhalb der genutzten Library), vielleicht sind die ja als add-on auch interessant, hier eine Übersicht:
https://dtaidistance.readthedocs.io/en/latest/usage/dtw.html#dtw-distance-measure-between-two-time-series

Copy link
Member

@mirkolenz mirkolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you rebase the PR with the latest changes from the main branch? There were some dependency updates, so you will also need to recreate the poetry lockfile. Ideally, you could also apply the black or ruff formatter on the files so they have the same style as all other source code in this repo.

pyproject.toml Outdated Show resolved Hide resolved
cbrkit/sim/strings/__init__.py Outdated Show resolved Hide resolved
cbrkit/sim/collections.py Outdated Show resolved Hide resolved
cbrkit/sim/collections.py Outdated Show resolved Hide resolved
@mirkolenz mirkolenz changed the title To: Issue #1 (add similarity measures) Add similarity measures for time-series data Mar 27, 2024
cbrkit/sim/strings/__init__.py Outdated Show resolved Hide resolved
cbrkit/sim/collections.py Outdated Show resolved Hide resolved
cbrkit/sim/collections.py Outdated Show resolved Hide resolved
@mirkolenz
Copy link
Member

The tests are still failing, could you investigate this further?

@Martin-Hoppe
Copy link
Contributor Author

The tests are still failing, could you investigate this further?

I really dont know where those errors are coming from, since any pytest is running locally. I have changed the only thing that may look suspicious, but the nix command doesnt give enough detail for why it fails (it mentions one could run this, but i dont think i can run this?)
'nix log /nix/store/f8xqzxdnnpw6lgrdhgrrn4cd09z9pabr-python3.11-cbrkit-0.7.0.drv'

Interestingly pytest did have the error again for which i shared the image in the recent whatsapp message, on a second run, without any changes, it didnt happen though.

Copy link
Member

@mirkolenz mirkolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I investigated this locally and the main issue with the CI tests were missing dependencies: The timeseries extra was missing in the nix flake. I changed this and also updated some of the code and the types, it should be fine now. Thank you!

@mirkolenz mirkolenz merged commit 53bb481 into wi2trier:main Apr 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants