-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add similarity measures for time-series data #80
Conversation
add similarit function: regex, glob_regex, n-grams, smith-watmerman, dynamic time warping
Es gibt noch einige andere Similarities beim DTW (auch innerhalb der genutzten Library), vielleicht sind die ja als add-on auch interessant, hier eine Übersicht: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Could you rebase the PR with the latest changes from the main branch? There were some dependency updates, so you will also need to recreate the poetry lockfile. Ideally, you could also apply the black or ruff formatter on the files so they have the same style as all other source code in this repo.
add similarit function: regex, glob_regex, n-grams, smith-watmerman, dynamic time warping
# Conflicts: # poetry.lock # pyproject.toml
remove import
change imports, comments
make it pass tests:
remake poetry file
The tests are still failing, could you investigate this further? |
fix the failing tests (?)
I really dont know where those errors are coming from, since any pytest is running locally. I have changed the only thing that may look suspicious, but the nix command doesnt give enough detail for why it fails (it mentions one could run this, but i dont think i can run this?) Interestingly pytest did have the error again for which i shared the image in the recent whatsapp message, on a second run, without any changes, it didnt happen though. |
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I investigated this locally and the main issue with the CI tests were missing dependencies: The timeseries extra was missing in the nix flake. I changed this and also updated some of the code and the types, it should be fine now. Thank you!
add dtaidistance, minineedle dependency
add similarit function: regex, glob_regex, n-grams, smith-watmerman, dynamic time warping