Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add narrative to Tales #131

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Add narrative to Tales #131

merged 2 commits into from
Aug 13, 2018

Conversation

Xarthisius
Copy link
Collaborator

This PR introduces Tale's narrative, i.e. a set of scripts/files/notebooks that is going to be injected into the working directory upon Tale instantiation. In case of '.ipynb' and '.Rmd' files we could default to opening them after start in Jupyter and Rstudio respectively.
This feature will be divided into three stages:

  1. Adding narrative support in Tale model (this PR)
  2. Injecting narrative content into Tale Instance (PR to gwvolman)
  3. UI modification, that would allow users to use narrative (PR to dashboard)

Stage 3 is outside of scope of v0.5 milestone. However, 1 and 2 will be used to address whole-tale/gwvolman#14

@Xarthisius Xarthisius added this to the 0.5 milestone Aug 2, 2018
@codecov
Copy link

codecov bot commented Aug 2, 2018

Codecov Report

Merging #131 into master will increase coverage by 0.8%.
The diff coverage is 96.29%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #131     +/-   ##
=========================================
+ Coverage   77.98%   78.78%   +0.8%     
=========================================
  Files          20       20             
  Lines        1649     1669     +20     
=========================================
+ Hits         1286     1315     +29     
+ Misses        363      354      -9
Impacted Files Coverage Δ
server/schema/tale.py 100% <ø> (ø) ⬆️
server/rest/tale.py 87.75% <ø> (ø) ⬆️
server/constants.py 80% <100%> (+0.51%) ⬆️
server/models/tale.py 89.39% <96.15%> (+9.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e7e91a...9be3c31. Read the comment docs.

@ThomasThelen
Copy link
Member

LGTM This should be a really nice feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants