Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce nova-kit/nova-packages-tool #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

webard
Copy link

@webard webard commented Sep 24, 2024

This PR introduces nova-kit/nova-packages-tool, which reduces the size of production card.js from 157 KB to 11.5 KB.

wip

Verified

This commit was signed with the committer’s verified signature.
kraftbj Brandon Kraft
@whitespacecode
Copy link
Owner

Hi @webard thank you for your pull request.
I have tested the request and notice a bug.

TypeError: Cannot read properties of undefined (reading 'props')
    at li (runtime-core.esm-bundler.js:4218:20)
    at r (runtime-core.esm-bundler.js:4225:29)
    at Array.forEach (<anonymous>)
    at li (runtime-core.esm-bundler.js:4237:19)
    at xa (runtime-core.esm-bundler.js:7464:19)
    at O (runtime-core.esm-bundler.js:5889:48)
    at V (runtime-core.esm-bundler.js:5874:9)
    at w (runtime-core.esm-bundler.js:5342:11)
    at B (runtime-core.esm-bundler.js:5590:7)
    at C (runtime-core.esm-bundler.js:5497:7) 

I'm using the nova-table-card as a Card on my Dashboard.

class Main extends Dashboard
{
    public function cards()
    {
        return [
            new LatestConfigurations,
        ];
    }

    public function name()
    {
        return 'Dashboard';
    }
}

@webard
Copy link
Author

webard commented Sep 25, 2024

Hmm, I can’t reproduce this issue. I’m using this package in several places (dashboards and as a card in resources), and all of them are working fine, without any error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants