New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offset support for `Pagerfanta` #276

Open

matjaz321 wants to merge 2 commits into whiteoctober:master from matjaz321:ca

matjaz321 commented Apr 3, 2019

Problem

There was currently no way to have offset for pagerfanta 😞

Solution

Offset is now working and I also added simple test 😄

matjaz321 added 2 commits

April 3, 2019 11:08


          Added offset support for Pagerfanta and tests

3322d85


          Removed type hint for PagerfantaTest::dataProviderTestOffset

366cd09

Contributor

stof commented Apr 3, 2019

this is broken, as you don't take the offset into account when computing the number of pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet