[RFC] Lazy adapters implementation #183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example of lazy adapter for Sphinxsearch engine https://github.com/Koc/Sphinxy/blob/master/Pagerfanta/Adapter/SphinxyQbAdapter.php |
|
Looks interesting for elasticsearch, too: For example: I need aggregations from PagerfantaAdpter which are the same on all pages. EDIT: Your PR is missing the actual |
|
|
||
| if ($this->adapter instanceof LazyAdapterInterface) { | ||
| $page = $this->filterOutOfRangeCurrentPage($this->getCurrentPage()); | ||
| if ($page != $this->getCurrentPage()) { |
There was a problem hiding this comment.
should use a string comparison
There was a problem hiding this comment.
Did you mean (string)$page !== (string)$this->getCurrentPage()?
|
@mablae |
|
Tests have been added |
|
Unfortunately the problem with double queries is still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use case: some databases/search engines aren't required execute two queries for getting count and slice. So we can use only one query for slice and count, but now it doesn't work properly, because Pagerfanta filters current page so early, before slice query executed.
For preventing +1 query I've created
LazyAdapterInterfacethat marks adapter as lazy.TODO: