Dockerfile: Fix bug by adding group by id not name #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
When a group already exists with the specified gid, usermod with -f will silently added the group with a default new gid. So worker ends up with an extra useless group rather than the one specified. Signed-off-by: Chris Harding <[email protected]>
sjrct
force-pushed
the
fix-group-already-exists
branch
from
3fcb6bd
to
b40ec2d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into this issue on solus trying to build the image with a specified gid when the gid (15) already existed.
When a group already exists with the specified gid,
usermod -fwill silently added the group with a default new gid (eg 1001). Soworkerends up with an extra useless group rather than the one specified. This fixes the issue by adding the group by the gid rather than by the name, soworkeralways ends up with the gid you want (even if that isn't the newly createdopticalgroup)